Skip to content

fix(etcd): initialize ResourceVersion in NewObjectStoreCluster (#352) #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(etcd): initialize ResourceVersion in NewObjectStoreCluster (#352) #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ac02c9
fix(etcd): initialize ResourceVersion in NewObjectStoreCluster
arpitjain099 Jun 28, 2026
707f9d2
test(etcd): drop the explanatory comment on the cluster-store regress…
arpitjain099 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/storage/etcd/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,11 @@ type objectStoreCluster[T metav1.Object] struct {
func NewObjectStoreCluster[T metav1.Object](client clientv3.KV, gvk schema.GroupVersionKind, gr schema.GroupResource) api.GenericClusterIface[T] {
return &objectStoreCluster[T]{
store: &objectStoreNamespaced[T]{
namespaced: false,
etcdclient: client,
gvk: gvk,
gr: gr,
ResourceVersion: versioning.NewVersioning(),
namespaced: false,
etcdclient: client,
gvk: gvk,
gr: gr,
},
}
}
Expand Down
21 changes: 21 additions & 0 deletions pkg/storage/etcd/store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package etcd

import (
"testing"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
)

func TestClusterStoreUseResourceVersionNoPanic(t *testing.T) {
gvk := schema.GroupVersionKind{Group: "wgpolicyk8s.io", Version: "v1alpha2", Kind: "ClusterPolicyReport"}
gr := schema.GroupResource{Group: "wgpolicyk8s.io", Resource: "clusterpolicyreports"}

// A nil KV client is fine: UseResourceVersion only touches the in-memory
// versioning struct and never talks to etcd.
store := NewObjectStoreCluster[metav1.Object](nil, gvk, gr)

if got := store.UseResourceVersion(); got == "" {
t.Fatalf("expected a non-empty resource version, got %q", got)
}
}