fix(install): warn for known affected ublk kernels - #93
Conversation
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
|
Addressed the latest suffix-matching review and completed an independent Linux validation on head
The targeted cases include Azure kernel releases with |
|
@yingdi-shan This is ready for maintainer review when convenient. The current head is mergeable; AENV CI, unit tests, clippy, both E2E jobs, agentenv tests, and OpenCodeReview are all green, and both review threads are resolved. |
|
Thank you for your contribution! I left a comment on issue #20. I suggest updating only the installation script instead of modifying the entire script, as this keeps the change more focused. |
e65b73f to
6d1ae9e
Compare
|
Thanks, I narrowed the PR to that scope in |
| cat >&2 <<EOF | ||
| warning: Linux kernel ${KERNEL_RELEASE} is known to contain a ublk initialization regression. | ||
| Creating the first ublk device may hang or panic the host. | ||
| Upgrade to a fixed vendor kernel (upstream 6.18.6+ for 6.18.y) before running AgentENV. | ||
| See: https://github.com/kvcache-ai/AgentENV/issues/20 | ||
| EOF | ||
| ;; |
There was a problem hiding this comment.
[bug · high]
The matched-kernel path only emits a warning and then continues. With the default SKIP_SETUP=0, this script subsequently invokes server --setup-host, which provisions ublk and may trigger the exact host hang/panic described here. Abort before setup on affected kernels (optionally allowing an explicit unsafe override), rather than proceeding automatically.
Suggestion:
| cat >&2 <<EOF | |
| warning: Linux kernel ${KERNEL_RELEASE} is known to contain a ublk initialization regression. | |
| Creating the first ublk device may hang or panic the host. | |
| Upgrade to a fixed vendor kernel (upstream 6.18.6+ for 6.18.y) before running AgentENV. | |
| See: https://github.com/kvcache-ai/AgentENV/issues/20 | |
| EOF | |
| ;; | |
| cat >&2 <<EOF | |
| error: Linux kernel ${KERNEL_RELEASE} is known to contain a ublk initialization regression. | |
| Creating the first ublk device may hang or panic the host. | |
| Upgrade to a fixed vendor kernel (upstream 6.18.6+ for 6.18.y) before running AgentENV. | |
| See: https://github.com/kvcache-ai/AgentENV/issues/20 | |
| EOF | |
| exit 1 | |
| ;; |
| case "$KERNEL_RELEASE" in | ||
| 6.18.4|6.18.4[-+]*|6.18.5|6.18.5[-+]*|\ | ||
| 6.17.0-1015-azure|6.17.0-1015-azure[-+]*|\ | ||
| 6.17.0-1018-azure|6.17.0-1018-azure[-+]*) |
There was a problem hiding this comment.
We can add 6.17.0-1020-azure. Other kernels like 6.17.0-1018-aws also contain the vulnerability.
| case "$KERNEL_RELEASE" in | ||
| 6.18.4|6.18.4[-+]*|6.18.5|6.18.5[-+]*|\ | ||
| 6.17.0-1015-azure|6.17.0-1015-azure[-+]*|\ | ||
| 6.17.0-1018-azure|6.17.0-1018-azure[-+]*) |
There was a problem hiding this comment.
This code is duplicated with install.sh. Maybe we can add a file with affeted kernel version and read kernel versions from that file?
Summary
scripts/install.shwhen the running kernel is a known affected ublk releaseublk_drvScope
This revision follows the maintainer guidance on #20 and replaces the earlier
runtime guard with an installation-only warning. The PR now changes only:
scripts/install.shscripts/docker-setup.shThe delimiter-aware shell patterns cover the known upstream
6.18.4/6.18.5families and Ubuntu Azure
6.17.0-1015/6.17.0-1018, including-and+local-version suffixes without overmatching releases such as
6.18.40.Validation
git diff --checkFixes #20