🐛 fix: improve graceful shutdown handling - #2
Open
sliver2er wants to merge 3 commits into
Open
Conversation
- build:webapp 스크립트에 npm install 추가 - webapp node_modules 미설치 시 빌드 실패하는 문제 해결 - README 로컬 개발 가이드 문구 명확화
- minimatch 9.0.5 -> 9.0.9 - qs 6.14.1 -> 6.14.2 - 패키지명 claude-viz -> viewcc 반영
- Track SSE clients and broadcast shutdown event before closing - Destroy active sockets on shutdown to prevent hanging - Add isShuttingDown flag to prevent duplicate shutdown calls - Server now closes immediately on Ctrl+C instead of requiring multiple presses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Problem
Previously, the server would hang on shutdown because:
server.close()would wait for all connections to close before triggering the callbackSolution
isShuttingDownflag to prevent duplicate shutdown handlersTesting