Skip to content

ECOPROJECT-4807 | feat: add created_at timestamp to inventory schema #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nirarg merged 1 commit into from
Aug 10, 2026
Merged

ECOPROJECT-4807 | feat: add created_at timestamp to inventory schema #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 67 additions & 67 deletions api/v1alpha1/agent/spec.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions api/v1alpha1/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2313,6 +2313,10 @@ components:
vcenter:
$ref: "#/components/schemas/InventoryData"
description: vCenter-level inventory data
created_at:
type: string
format: date-time
description: Timestamp when the inventory data was created or collected
Comment on lines +2316 to +2319

@coderabbitai coderabbitai Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Allow explicit null for backward compatibility.

created_at is optional but not nullable, so schema-aware clients or validators can reject existing payloads containing "created_at": null, even though the generated Go pointer accepts it. Add nullable: true and regenerate the embedded specifications.

This follows the PR objective that existing data may deserialize with created_at: null.

Proposed schema fix 
         created_at:
           type: string
           format: date-time
+          nullable: true
           description: Timestamp when the inventory data was created or collected
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
created_at:
type: string
format: date-time
description: Timestamp when the inventory data was created or collected
created_at:
type: string
format: date-time
nullable: true
description: Timestamp when the inventory data was created or collected
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@api/v1alpha1/openapi.yaml` around lines 2316 - 2319, Update the created_at
property in the OpenAPI schema to explicitly allow null values by adding
nullable: true, then regenerate all embedded/generated specifications so the
schema and generated artifacts remain consistent.


ClusterUtilization:
type: object
Expand Down
Loading
Loading