Draft: 🐋 Add yaml-lint github action and add .editorconfig#512
Draft: 🐋 Add yaml-lint github action and add .editorconfig#512tzabbi wants to merge 7 commits intokubetail-org:mainfrom
Conversation
…-org#389) Signed-off-by: Tom Zaspel <tom@zaspel.it>
…l-org#389) Signed-off-by: Tom Zaspel <tom@zaspel.it>
Signed-off-by: Tom Zaspel <tom@zaspel.it>
amorey
left a comment
There was a problem hiding this comment.
Let's ignore pnpm-lock.yaml and other generated yaml files because otherwise we'll be in constant contention with the code generators
| with: | ||
| python-version: "3.x" | ||
|
|
||
| - name: Install yamllint |
There was a problem hiding this comment.
Does it make sense to use a one-step yamllint action? I don't have any personal experience with them but here are some options:
https://github.com/marketplace/actions/yaml-lint
https://github.com/marketplace/actions/yamllint-github-action
There was a problem hiding this comment.
I just used the example from the yaml lint documentation: https://yamllint.readthedocs.io/en/latest/integration.html#integration-with-github-actions
amorey
left a comment
There was a problem hiding this comment.
The current .editorconfig settings will contend with the gofmt tool that uses tabs instead of spaces. Considering that this is a multi-language monorepo does it make more sense to configure each language formatter separately?
Signed-off-by: Tom Zaspel <tom@zaspel.it>
|
I will fix everything after my vacation. |
|
@amorey do you have some requirements for rust, go, ... files in regard of code syntax? I will add them to the .editorconfig. Same for the yaml linter, which files will be autogenerated? |
25b2011 to
c521683
Compare
Signed-off-by: Tom Zaspel <tom@zaspel.it>
Signed-off-by: Tom Zaspel <tom@zaspel.it>
Fixes #510
Summary
Add yaml-lint github action job and .editorconfig
Changes
Submitter checklist
Footnotes
See suggested commit format ↩