[neolit123]

Add two optional presubmits for kubeadm that test:

• upgrade with in-place version (latest->latest) at k/k master for incoming PRs.
• dry-running kubeadm e2e works for k/k master PRs.

xref

• run some non-blocking pre-submits if kubeadm dirs in k/k are touched kubeadm#3332
• kinder: add a new script to be used with the k/k CI kubeadm#3333

existing kinder periodic jobs are running here and are green:

• https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm

that script that is being called is here:

• kinder: add a new script to be used with the k/k CI kubeadm#3333

it's based on some existing GH action CI that we have to trigger manually for a PR number. we've used that for a few years by now:
https://github.com/neolit123/kubeadm-test/actions/workflows/k8s-test-pr.yaml

[neolit123]

/assign @BenTheElder @pohly @aojea
SIG Testing TLs, PTAL.

[BenTheElder]

I think this probably makes sense but I'd like a +1 from another TL

Can you elaborate a little bit on what the dryrun does? Do we have an existing periodic or similar we can look at?

If not, let's start with the run_if_changed commented out until we know the job is stable?

[BenTheElder]

(It looks like we're pending a new script that hasn't been run yet?)

[neolit123]

(It looks like we're pending a new script that hasn't been run yet?)

i tested the script locally. once the job entries are there we can amend the script if something is broken in CI.
in the meantime i pinged folks to approve that PR.

Can you elaborate a little bit on what the dryrun does? Do we have an existing periodic or similar we can look at?

that periodic is defined here:
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-dryrun-latest

it's a set of tasks in bash that execute the main kubeadm commands (init/join/upgrade) with --dry-run. it enables faking API server responses with a fake clientset, allowing the users to dry run the commands.

https://github.com/kubernetes/kubeadm/blob/main/kinder/ci/workflows/dryrun-tasks.yaml
https://github.com/kubernetes/kubeadm/blob/main/kinder/ci/workflows/presubmit-upgrade-tasks.yaml

(note to self: i need to enable the kubeadm_e2e suite for the upgrade job, the k8s e2e suite is skipped for both jobs)
(EDIT: done)

[pohly]

/lgtm

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-cluster-lifecycle/OWNERS [neolit123]
• config/tests/jobs/policy/OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

@neolit123: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key kubeadm-kinder-kubernetes-presubmits.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-kubernetes-presubmits.yaml

Details

In response to this:

Add two optional presubmits for kubeadm that test:

• upgrade with in-place version (latest->latest) at k/k master for incoming PRs.
• dry-running kubeadm e2e works for k/k master PRs.

xref

• run some non-blocking pre-submits if kubeadm dirs in k/k are touched kubeadm#3332
• kinder: add a new script to be used with the k/k CI kubeadm#3333

existing kinder periodic jobs are running here and are green:

• https://testgrid.k8s.io/sig-cluster-lifecycle-kubeadm

that script that is being called is here:

• kinder: add a new script to be used with the k/k CI kubeadm#3333

it's based on some existing GH action CI that we have to trigger manually for a PR number. we've used that for a few years by now:
https://github.com/neolit123/kubeadm-test/actions/workflows/k8s-test-pr.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.