Skip to content

kinder: add a new script to be used with the k/k CI - #3333

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes:mainfrom
neolit123:1.38-add-a-k-k-presubmit-script
Oct 25, 2026
Merged

kubernetes-prow[bot] merged 2 commits into
kubernetes:mainfrom
neolit123:1.38-add-a-k-k-presubmit-script

Conversation

@neolit123

@neolit123 neolit123 commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

A similar script exists already in a GH action form: https://github.com/neolit123/kubeadm-test/actions/workflows/k8s-test-pr.yaml

What this does is the following:

  • takes a dir where k/k is and builds kubeadm from it.
  • takes the target kinder workspace which we want to run and injects a new task to replace the kubeadm binaries for init and upgrade.
  • runs the modified workflow with kinder.

xref

EDIT: second commit disables the e2e_kubeadm suite dry-run so that we can catch bugs in the k/k kubeadm suite.

A similar script exists already in a GH action form:
https://github.com/neolit123/kubeadm-test/actions/workflows/k8s-test-pr.yaml

What this does is the following:
- takes a dir where k/k is and builds kubeadm from it.
- takes the target kinder workspace which we want to run
and injects a new task to replace the kubeadm binaries for init
and upgrade.
- runs the modified workflow with kinder.
@kubernetes-prow kubernetes-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2026
@kubernetes-prow kubernetes-prow Bot added area/kinder Issues to track work in the kinder tool approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2026
Since we plan to run this same workflow in k/k presubmits
we want to build and run the kubeadm e2e test suite; not
only dry-run it.
@neolit123
neolit123 force-pushed the 1.38-add-a-k-k-presubmit-script branch from e687599 to 033b5fc Compare October 23, 2026 07:51
@neolit123 neolit123 changed the title WIP: kinder: add a new script to be used with the k/k CI kinder: add a new script to be used with the k/k CI Oct 23, 2026
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2026

@HirazawaUi HirazawaUi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [HirazawaUi,neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot merged commit 1f0220b into kubernetes:main Oct 25, 2026
4 checks passed
@HirazawaUi

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants