KEP-5963: DRA Device Compatibility Groups#5964
KEP-5963: DRA Device Compatibility Groups#5964omeryahud wants to merge 3 commits intokubernetes:masterfrom
Conversation
|
Welcome @omeryahud! |
|
Hi @omeryahud. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
81a89cb to
9c9c306
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omeryahud The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Omer Yahud <oyahud@nvidia.com>
9c9c306 to
a31625a
Compare
Signed-off-by: Omer Yahud <oyahud@nvidia.com>
Signed-off-by: Omer Yahud <oyahud@nvidia.com>
rajatchopra
left a comment
There was a problem hiding this comment.
Looks good. Subject to schedulers willing to adopt these suggestions.
| Add a `device.consumesCounters[].compatibilityGroups` field. Devices declare which | ||
| named groups they belong to. For two devices consuming counters from the same | ||
| counter set to be co-allocated, they must share at least one compatibility group. | ||
| Devices without this field are considered compatible with all groups. This |
There was a problem hiding this comment.
Should the default be 'not compatible with any group'? And for compatibility with all (or some) we can use a regex? Like '*'. Regex may have more benefits like 'fft-accelerator-*' to claim fmm-accelerator compatibility with all fft-accelerators. But mutual exclusivity between intra fmm and fft devices.
Then, an older version slice and a newer scheduler will automatically mean mutual exclusivity.
|
|
||
| ### Scheduler Changes | ||
|
|
||
| The DRA scheduler plugin is enhanced to: |
There was a problem hiding this comment.
Will it help the scheduler to know upfront the list of compatibility groups? Or is reaping the list from devices in a slice good enough?
We may want a .sharedCounters[].compatibilityGroups field if it makes it easier for the scheduler. Also makes the spec 'compile-correct'.
|
/assign @alaypatel07 |
Uh oh!
There was an error while loading. Please reload this page.