Adding out-of-tree azure credentail provider set up to CAPZ templates#562
Merged
k8s-ci-robot merged 1 commit intoMay 18, 2026
Merged
Conversation
k8s-ci-robot
added
tide/merge-method-squash
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
marosset
force-pushed
the
capz-templates-oot-cred-provider
branch
from
fa7b372 to
74e051e
Compare
Contributor
Author
zylxjtu
reviewed
May 18, 2026
| } | ||
|
|
||
| prepare_cloud_provider_azure() { | ||
| if [[ "${CLOUD_PROVIDER_AZURE_ARTIFACTS_READY:-}" == "true" ]]; then |
Contributor
There was a problem hiding this comment.
nit: if we remove line 418, maybe we do not need these 3 lines of check here.
Contributor
|
Any ways for us to validate this will work well with CCM/CSI test suites? |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, zylxjtu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
not without adding another PR job in test-infra. I am going to re-trigger the CCM job now tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of kubernetes-sigs/cluster-api-provider-azure#6305
This PR sets up an out-of-tree credential provider on the control-plane and windows nodes to support running the cloud-controller-manager tests (which were switched to using windows-testing infra as part of kubernetes/test-infra#37026)