statusreconciler: skip draft PRs in triggerNewPresubmits

[carterpewpew]

GetPullRequests returns all open PRs, including drafts. In status-reconciler, triggerNewPresubmits iterated all open PRs and called RunRequested directly, so trusted draft PRs could receive newly-added blocking presubmits during config reconciliation.

The trigger plugin already skips drafts via buildAllButDrafts, but status-reconciler bypassed that path. This change adds the same draft guard in triggerNewPresubmits (before the existing mergeable check) so drafts are skipped early. Non-draft behavior is unchanged.

Retire and migrate operations are intentionally unchanged: they continue to apply to all PRs (including drafts) because status contexts still need cleanup/migration.

Test follows the existing unmergable-PR pattern and verifies draft PRs are not triggered.

Fixes: #190

[netlify]

✅ Deploy Preview for k8s-prow ready!

Name	Link
🔨 Latest commit	79ed8a4
🔍 Latest deploy log	https://app.netlify.com/projects/k8s-prow/deploys/69f2f89ed7253900096c4a7c
😎 Deploy Preview	https://deploy-preview-699--k8s-prow.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[k8s-ci-robot]

Welcome @carterpewpew!

It looks like this is your first PR to kubernetes-sigs/prow 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/prow has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @carterpewpew. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Prucek]

So, with this PR, you are trying to ensure that the PR's presubmit contexts aren't created on a draft PR?
Here we have a draft PR: openshift/ci-tools#5030, no presubmit is triggered.

[carterpewpew]

So, with this PR, you are trying to ensure that the PR's presubmit contexts aren't created on a draft PR? Here we have a draft PR: openshift/ci-tools#5030, no presubmit is triggered.

Thank you @Prucek for taking a look, The example you linked is the trigger plugin correctly skipping CI on a draft PR push that path already handles drafts. This fix is for a different code path: when a new blocking presubmit is added to the config, the status-reconciler's triggerNewPresubmits queries all open PRs via GetPullRequests (which includes drafts) and triggers the new job for them. That reconciliation path didn't have a draft check before this.

[petr-muller]

/test all

[petr-muller]

@Prucek there's #190 filed for the problem. presubmits do not trigger on draft PRs, but when status-reconciler triggers new jobs it does so even on draft PRs which is inconsistent and wasteful. I'll /approve and leave lgtm on you.

@carterpewpew can you add Fixes: #190 to your description?

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carterpewpew, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[carterpewpew]

@Prucek there's #190 filed for the problem. presubmits do not trigger on draft PRs, but when status-reconciler triggers new jobs it does so even on draft PRs which is inconsistent and wasteful. I'll /approve and leave lgtm on you.

@carterpewpew can you add Fixes: #190 to your description?

/approve

Done, thanks again

[Prucek]

/lgtm