Skip to content

[release-1.20] upgrade to go 1.26.10 to fix CVE-2026-111943 - #1242

Merged
andyzhangx merged 2 commits into
kubernetes-csi:release-1.20from
andyzhangx:release-1.20-go12610-20261023
Oct 23, 2026
Merged

andyzhangx merged 2 commits into
kubernetes-csi:release-1.20from
andyzhangx:release-1.20-go12610-20261023

Conversation

@andyzhangx

Copy link
Copy Markdown
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Update release-1.20, following livenessprobe#465 and csi-release-tools#321, to build with Go 1.26.10 for CVE-2026-111943.

  • Based on the latest csi-driver-smb:release-1.20 at 8e91007392afe928c15380bbea0a294b144e891d, rechecked before push. This PR targets release-1.20, not master.
  • Update release-tools from 7bacb813921c5b269bc4ba218d518004dda5288e to latest upstream master 94dd4dae3245f7f8a0d731e16a73995e90ad84ff using:
    git subtree pull --squash --prefix=release-tools https://github.com/kubernetes-csi/csi-release-tools.git master
  • Upgrade CSI_PROW_GO_VERSION_BUILD from 1.26.9 to 1.26.10.
  • Align the top-level .github/workflows/trivy.yaml Go pin to 1.26.10, so the workflow's locally built scan image uses the updated toolchain too.
  • Preserve subtree history metadata and branch-specific code. The existing Windows HostProcess customization in release-tools/build.make is preserved byte-for-byte. Its residual diff against upstream is identical before and after the import; all other subtree files match upstream.

The release branch already includes preceding release-tools updates, so this PR changes exactly two lines in two files. No driver/runtime code, dependencies, CA packages, or vulnerability ignore entries are modified.

Security context and scope

As described in Go issue #82345 and csi-release-tools#321, CVE-2026-111943 concerns certificate trust in specific CA intermediates. Go's crypto/x509 mitigation filters chains containing the distrusted intermediates out of Certificate.Verify results. The Go security team classified this as URGENT-track.

This updates the build toolchain only. Existing binaries and published images must still be rebuilt, published, and deployed; the change does not retroactively patch them. Actual exposure depends on TLS verification paths and trust configuration. Go's compiled standard-library mitigation and updates to OS CA packages/non-Go TLS clients are separate tasks; this PR does not claim that all image or OS-package vulnerabilities are resolved.

Which issue(s) this PR fixes:
Related to kubernetes-csi/csi-release-tools#321 and golang/go#82345.

Special notes for your reviewer:
Validation:

  • git diff --check passes; verified the exact two-line/two-file scope.
  • bash -n passes for all 17 top-level release-tools/*.sh scripts.
  • Trivy workflow YAML parses and both Go version pins are 1.26.10.
  • The existing Windows HostProcess customization in release-tools/build.make is preserved byte-for-byte. Its residual diff against upstream is identical before and after the import; all other subtree files match upstream.

No component/image build, Trivy scan, Windows build, or cluster E2E run was performed locally (Go, Make, and Docker are unavailable).

Does this PR introduce a user-facing change?:
/release-note-none

NONE

94dd4dae Merge pull request kubernetes-csi#321 from andyzhangx/patch-17
678187e1 upgrade to go 1.26.10 to fix CVE-2026-111943

git-subtree-dir: release-tools
git-subtree-split: 94dd4dae3245f7f8a0d731e16a73995e90ad84ff
Signed-off-by: andyzhangx <xiazhang@microsoft.com>
@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from jingxu97 and pohly October 23, 2026 03:36
@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2026
@andyzhangx
andyzhangx merged commit aabf299 into kubernetes-csi:release-1.20 Oct 23, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant