Skip to content

perf(react): DragAndDropObserver parent offset object reusing #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krutoo merged 1 commit into from
Aug 20, 2026
+27 −15
Merged

perf(react): DragAndDropObserver parent offset object reusing #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions src/react/drag-and-drop/observer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ export class DragAndDropObserver {

protected plugins: DragAndDropPluginManager;

protected sharedEvent?: DnDEvent<Event>;
protected allocated: {
event?: DnDEvent<Event>;
positionedParentOffset?: Point2d;
};

protected observation?: {
readonly element: HTMLElement;
Expand All @@ -33,6 +36,7 @@ export class DragAndDropObserver {
reuseEvent: true,
...options,
};

this.state = {
pointerId: -1,
pressed: false,
Expand All @@ -41,6 +45,12 @@ export class DragAndDropObserver {
startOffset: Vector2.of(0, 0),
innerOffset: Vector2.of(0, 0),
};

this.allocated = {
event: undefined,
positionedParentOffset: this.options.reuseEvent ? { x: 0, y: 0 } : undefined,
};

this.plugins = createPluginManager(() => this.state);
}

Expand All @@ -66,7 +76,9 @@ export class DragAndDropObserver {
return clientPosition
.clone()
.subtract(innerOffset)
.subtract(getPositionedParentOffset(element, this.options));
.subtract(
getPositionedParentOffset(element, this.options, this.allocated.positionedParentOffset),
);
},
};

Expand Down Expand Up @@ -208,23 +220,23 @@ export class DragAndDropObserver {
return new DnDEvent(target, state, nativeEvent, clientPosition);
}

if (!this.sharedEvent) {
this.sharedEvent = new DnDEvent(target, state, nativeEvent, clientPosition);
if (!this.allocated.event) {
this.allocated.event = new DnDEvent(target, state, nativeEvent, clientPosition);

return this.sharedEvent as DnDEvent<E>;
return this.allocated.event as DnDEvent<E>;
}

this.sharedEvent.target = target;
this.sharedEvent.nativeEvent = nativeEvent;
this.sharedEvent.clientPosition = clientPosition;
this.sharedEvent.grabbed = state.grabbed;
this.sharedEvent.pressed = state.pressed;
this.sharedEvent.offset = state.offset;
this.sharedEvent.startOffset = state.startOffset;
this.sharedEvent.innerOffset = state.innerOffset;
this.allocated.event.target = target;
this.allocated.event.nativeEvent = nativeEvent;
this.allocated.event.clientPosition = clientPosition;
this.allocated.event.grabbed = state.grabbed;
this.allocated.event.pressed = state.pressed;
this.allocated.event.offset = state.offset;
this.allocated.event.startOffset = state.startOffset;
this.allocated.event.innerOffset = state.innerOffset;

DnDEvent.resetPrevention(this.sharedEvent);
DnDEvent.resetPrevention(this.allocated.event);

return this.sharedEvent as DnDEvent<E>;
return this.allocated.event as DnDEvent<E>;
}
}
Loading