Repository navigation
Conversation
Why
Every invocation of the plugin previously created a new interval that retained the selected DOM collection indefinitely, leading to memory leaks and duplicate timer execution.
How
Stored a single timer instance per element using jQuery's .data("timeago-timer"). Added logic to explicitly clear any existing timer (clearInterval(existingTimer)) before initializing a replacement. Introduced an attachment check (isAttached) inside the refresh loop that automatically stops the interval and cleans up the timer data once the element is detached from the document.
Security/Robustness changes
Eliminates client-side memory leaks and CPU exhaustion by ensuring that detached DOM nodes can be properly garbage collected.
Testing
Verified that jquery-timeago/jquery.timeago.js passes standard node --check validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every invocation of the plugin previously created a new interval that retained the selected DOM collection indefinitely, leading to memory leaks and duplicate timer execution.
How
Stored a single timer instance per element using jQuery's .data("timeago-timer"). Added logic to explicitly clear any existing timer (clearInterval(existingTimer)) before initializing a replacement. Introduced an attachment check (isAttached) inside the refresh loop that automatically stops the interval and cleans up the timer data once the element is detached from the document.
Security/Robustness changes
Eliminates client-side memory leaks and CPU exhaustion by ensuring that detached DOM nodes can be properly garbage collected.
Testing
Verified that jquery-timeago/jquery.timeago.js passes standard node --check validation.