feat(bulkProcessing): near limit alert DEV-1399 by magicznyleszek · Pull Request #7232 · kobotoolbox/kpi

magicznyleszek · 2026-07-09T12:55:17Z

🗒️ Checklist

📣 Summary

Adds a new Near Limit error alert to bulk transcription and bulk translation modals, shown when a user still has quota left but not enough to process all selected submissions.

💭 Notes

Changes here:

Near-limit evaluator is now implemented in the bulk alerts pipeline.
Near-limit is treated as an error (blocking), so users cannot continue until they reduce selection or increase quota.
Both modals now provide near-limit required amounts into the shared alert hook.
Unit coverage was extended for near-limit scenarios (show/hide behavior and computed message values).

👀 Preview steps

ℹ️ Have a project with audio/transcript data.
Go to Project → Data → Table
Select submissions and open either:
- Bulk transcription modal, or
- Bulk translation modal.
If your account naturally has low remaining quota, use that directly and continue to step 6.
Optional local-testing shortcut (temporary code tweak to force near-limit):
- In BulkTranscriptionModal.tsx, temporarily multiply required seconds:
  - set near-limit required value (const nearLimitRequiredSeconds) to something like totalSelectedAudioDuration * 1000.
- In BulkTranslationModal.tsx, temporarily multiply required characters:
  - set near-limit required value to something like nearLimitRequiredCharacters * 1000.
Reload the page and reopen the modal with selected submissions.
🔴 [on main] Near-limit alert is not appearing.
🟢 [on PR] Near-limit error alert appears with remaining amount.

…dev-1399-near-limit-alert

magicznyleszek · 2026-07-09T13:55:56Z

@greptile-apps review please

greptile-apps · 2026-07-09T14:00:50Z

Greptile Summary

This PR implements the previously stubbed evaluateNearLimit alert evaluator, surfacing a blocking error in the bulk transcription and translation modals when a user has remaining quota but not enough to cover all selected submissions.

Near-limit evaluator implemented: evaluateNearLimit now compares the pre-computed required amount against the API's balance_value, firing only when 0 < remaining < required. Results are stored as raw seconds/characters and formatted via formatTimeFromSeconds for human-readable display, resolving the earlier Math.floor-to-minutes precision issue noted in previous review threads.
Pre-filtering for accuracy: Both modals now compute nearLimitRequiredAmount from a filtered submission set (excluding already-transcribed/already-translated rows) so the quota estimate aligns with what the API will actually process — addressing the false-positive blocking issue identified in prior reviews.
Removed legacy alerts: The inline fallback Alert components and their hasExceededLimit && activeAlerts.length === 0 guard conditions are removed now that the evaluator pipeline is complete, consolidating all quota-related feedback through BulkProcessingAlerts.

Confidence Score: 5/5

Safe to merge — the change is well-scoped to the alert pipeline and both modals, previous review concerns have been addressed, and no new defects were found.

The near-limit evaluator is correctly implemented with proper guards (missing data, zero required amount, non-positive balance), is mutually exclusive with the reached-limit path, and the pre-filtering in both modals aligns the quota estimate with the submissions that will actually consume quota. All three issues raised in the previous review cycle have been resolved. Unit test coverage for the new evaluator is thorough.

No files require special attention. The two modal files carry the most logic but both are internally consistent.

_{Reviews (6): Last reviewed commit: "cr fix" | Re-trigger Greptile}

magicznyleszek · 2026-07-09T15:10:11Z

@greptile-apps review again

duvld

Some questions

duvld · 2026-07-10T16:18:58Z

                {t('Start Transcription')}
              </ButtonNew>
            )}
            {hasExceededLimit && (


Should we change the logic here to also display this button if the user is requesting more than their ASR allowance? Or say something like "your selection will surpass the amount of ASR time you have left, please purchase an add-on or select fewer submissions"?

When user has not enough minutes left there will be an alert stating what are the options. Ignacio confirmed we don't want to display "Purchase add-on" button here - mu guess is that since user has some minutes left after all, we don't want to be forcing a purchase on them just yet

duvld · 2026-07-10T16:20:09Z

Same as the BulkTranscriptionModal. Should we remove this comment and update the logic here?

I removed both legacy alerts, since BulkProcessingAlerts are handling those cases already :)

duvld · 2026-07-10T16:52:44Z

+
+  const remainingAmount = balance.balance_value
+
+  if (remainingAmount <= 0 || remainingAmount >= nearLimitRequiredAmount) {


I don't think I'm reading this right. Why do we return an error if the user's remaining amount of time is greater than the audio duration time?

This is actually correct, I have added a comment to explain it :)

I will also simplify the code to not return that weird createInactiveResult but instead simple null

duvld · 2026-07-10T16:54:05Z

  selectedRegion?: string
  actionType: BulkActionType
+  /** Required amount for full job in base units: seconds (transcription) or characters (translation). */
+  nearLimitRequiredAmount?: number


I think we should rename this variable, at least it's a bit confusing for me. When we say "required amount for full job" we mean the return of the duration form useCalculateAudioDuration right? I think "near limit" adds some ambiguity when this is the actual duration number

duvld · 2026-07-10T16:54:44Z

+    assetUid: props.assetUid,
+  })
+
+  const nearLimitRequiredSeconds =


Same here about the variable name, I think it reads better if we drop the "near limit" prefix

duvld · 2026-07-10T16:59:12Z

+    assetUid: props.assetUid,
+  })
+
+  const nearLimitRequiredSeconds =


From what I understand in the preview steps, we want this number to be big to simulate not having enough ASR minutes left(?) I tried setting this to very large numbers (1,000,000,000,000) and Number.POSITIVE_INFINITY and the alert still doesn't show.

magicznyleszek · 2026-07-13T08:58:45Z

@copilot resolve the merge conflicts in this pull request

…bed-alert' into leszek/dev-1399-near-limit-alert # Conflicts: # jsapp/js/components/submissions/BulkProcessingModals/alerts/alertEvaluators.tests.ts

Copilot · 2026-07-13T09:02:54Z

@copilot resolve the merge conflicts in this pull request

Resolved in f27a5da by merging the latest leszek/dev-1410-already-transcribed-alert changes into this branch and fixing the conflict in alertEvaluators.tests.ts.

# Conflicts: # jsapp/js/components/submissions/BulkProcessingModals/BulkTranscriptionModal/BulkTranscriptionModal.tsx # jsapp/js/components/submissions/BulkProcessingModals/alerts/BulkProcessingAlerts.stories.tsx

magicznyleszek added 7 commits July 9, 2026 13:37

already transcribed alert code

95e8d7b

use seconds

9b9d314

fallback to formatTimeFromSeconds

c4e958c

add comment

d0ed10c

wip code

b5600da

cr fixes

74c5b76

Merge branch 'leszek/dev-1410-already-transcribed-alert' into leszek/…

5ad031d

…dev-1399-near-limit-alert

magicznyleszek requested a review from duvld July 9, 2026 12:55

magicznyleszek self-assigned this Jul 9, 2026

magicznyleszek added the Front end label Jul 9, 2026

magicznyleszek added 2 commits July 9, 2026 15:02

fix ts

adeca59

Merge branch 'leszek/dev-1410-already-transcribed-alert' into leszek/…

70c735c

…dev-1399-near-limit-alert

greptile-apps Bot reviewed Jul 9, 2026

View reviewed changes

cr fixes

5579acc

magicznyleszek marked this pull request as ready for review July 9, 2026 15:17

duvld reviewed Jul 10, 2026

View reviewed changes

Copilot AI and others added 3 commits July 10, 2026 17:30

Merge origin/main into leszek/dev-1410-already-transcribed-alert

df5ab5e

fix bulk alert singular copy

dfb1c87

biome fix

3541a3b

Copilot started work on behalf of magicznyleszek July 13, 2026 08:59 View session

Merge remote-tracking branch 'origin/leszek/dev-1410-already-transcri…

f27a5da

…bed-alert' into leszek/dev-1399-near-limit-alert # Conflicts: # jsapp/js/components/submissions/BulkProcessingModals/alerts/alertEvaluators.tests.ts

Copilot finished work on behalf of magicznyleszek July 13, 2026 09:03

Base automatically changed from leszek/dev-1410-already-transcribed-alert to main July 13, 2026 09:04

magicznyleszek added 2 commits July 13, 2026 11:07

Merge branch 'main' into leszek/dev-1399-near-limit-alert

21fa9e3

# Conflicts: # jsapp/js/components/submissions/BulkProcessingModals/BulkTranscriptionModal/BulkTranscriptionModal.tsx # jsapp/js/components/submissions/BulkProcessingModals/alerts/BulkProcessingAlerts.stories.tsx

biome fix

1bed4f2

cr fix

0175204


		const remainingAmount = balance.balance_value

		if (remainingAmount <= 0 \|\| remainingAmount >= nearLimitRequiredAmount) {

Uh oh!

Uh oh!

Conversation

magicznyleszek commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Checklist

📣 Summary

💭 Notes

👀 Preview steps

Uh oh!

magicznyleszek commented Jul 9, 2026

Uh oh!

greptile-apps Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

Uh oh!

magicznyleszek commented Jul 9, 2026

Uh oh!

duvld left a comment

Choose a reason for hiding this comment

Uh oh!

duvld Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magicznyleszek commented Jul 13, 2026

Uh oh!

Copilot AI commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

magicznyleszek commented Jul 9, 2026 •

edited

Loading

greptile-apps Bot commented Jul 9, 2026 •

edited

Loading

duvld Jul 10, 2026 •

edited

Loading