Skip to content

WIP: npm deps ci improvements #7074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
p2edwards wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

WIP: npm deps ci improvements #7074

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7784eef
Update npm packages for install with `aube`
p2edwards May 21, 2026
0fcdcc8
Batch of npm package upgrades
p2edwards May 21, 2026
29eb5d7
Add cooldown to dependabot ecosystems
p2edwards May 21, 2026
07e95c8
Include package.json hash in node_modules key
p2edwards May 21, 2026
75d8bef
Avoid node_modules cache for dependabot PRs
p2edwards May 21, 2026
537d698
Update deps, re-dupe style-loader and wait-on
p2edwards May 22, 2026
a108e0b
Lockfile after `npm install` (node 26, npm@11.12.1)
p2edwards May 22, 2026
d7dd138
Upgrade jest-environment-jsdom
p2edwards May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
cooldown:
default-days: 10
schedule:
# dependabot doesn't support cron
interval: "weekly"
Expand All @@ -16,6 +18,8 @@ updates:

- package-ecosystem: "npm"
directory: "/"
cooldown:
default-days: 10
schedule:
# dependabot doesn't support cron
interval: "daily"
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/npm-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,13 @@ jobs:

# Cache: Use cache for node_modules
# Keyed on os, node version, package-lock, and patches
- uses: actions/cache@v5
name: Check for cached node_modules
- name: Check for cached node_modules
uses: actions/cache@v5
id: cache-nodemodules
env:
cache-name: cache-node-modules
if: github.actor != 'dependabot[bot]' # skip for dependabot PRs
with:
path: node_modules
key: ${{ runner.os }}-build-${{ env.cache-name }}-node-${{ steps.resolved-node-version.outputs.NODE_VERSION }}-${{ hashFiles('**/package-lock.json', 'patches/**/*.patch') }}
key: ${{ github.repository }}/node_modules--${{ runner.os }}-${{ runner.arch }}--node-${{ steps.resolved-node-version.outputs.NODE_VERSION }}--${{ hashFiles('**/package.json', '**/package-lock.json', 'patches/**/*.patch') }}

# Cache hit: If the cache key matches,
# /node_modules/ will have been copied from a previous run.
Expand Down
3 changes: 2 additions & 1 deletion msw-mocks/mockServiceWorker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* - Please do NOT modify this file.
*/

const PACKAGE_VERSION = '2.11.3'
const PACKAGE_VERSION = '2.14.6'
const INTEGRITY_CHECKSUM = '4db4a41e972cec1b64cc569c66952d82'
Comment thread
greptile-apps[bot] marked this conversation as resolved.
const IS_MOCKED_RESPONSE = Symbol('isMockedResponse')
const activeClientIds = new Set()
Expand Down Expand Up @@ -205,6 +205,7 @@ async function resolveMainClient(event) {
* @param {FetchEvent} event
* @param {Client | undefined} client
* @param {string} requestId
* @param {number} requestInterceptedAt
* @returns {Promise<Response>}
*/
async function getResponse(event, client, requestId, requestInterceptedAt) {
Expand Down
Loading
Loading