Repository navigation
feat(baileys): externalize reconnect via internalReconnect=false + recreateSocket() - #5
Merged
Merged
Conversation
Provider 'disconnected' event left the session entry in activeSessions, so consumer reconnect via createSession() threw "Session already exists" and the connection stayed dropped until process restart. Now remove the entry (and detach listeners) before re-emitting SESSION_DISCONNECTED, so callers can recreate cleanly on transient drops (Baileys reason -1, 515, 503). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Default-off internal setTimeout-driven reconnect so consumers (e.g. baileys-keep-alive) can own the reconnect lifecycle. When internalReconnect=false, the provider always emits 'disconnected' on close (transient and terminal alike) so the consumer can react. Adds public recreateSocket() helper that resets the connection state and re-runs connect() — designed for use as a keepAlive reconnectFactory. Resolves the dead-cache class of bugs where BaileysProvider silently swapped its internal socket and downstream sessions held a stale reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets consumers own the reconnect lifecycle (e.g. via baileys-keep-alive's reconnectFactory) by gating BaileysProvider's internal setTimeout-driven retries behind a new `internalReconnect` option (default `false`).
When `internalReconnect: false`:
Also adds a public `recreateSocket()` helper for use as a `reconnectFactory` — resets connection flags and re-runs `connect()`.
Why
With three layers of reconnect logic (internal setTimeout, WaSP SESSION_DISCONNECTED, baileys-keep-alive) racing each other, downstream sessions held stale socket references after the provider's internal swap, surfacing as `Boom('Connection Closed')` on every send.
This change establishes a single source of truth for reconnect, owned by the consumer.
Test plan
🤖 Generated with Claude Code