stream push and publish progress (knit) - #176
Merged
Merged
Conversation
knit push and knit publish create spawned one worker per repo but joined every worker before printing anything, so with many repos and one slow origin the commands sat silent until the slowest push finished and then printed everything at once - which reads as a hang. Workers now report over a channel and the main thread prints each line the moment it happens: a 'pushing/publishing N repo(s)…' header, one 'pushed' line per repo as its branch reaches origin (publish emits this before it looks up or creates the review object), and a muted (done/total) tail on each repo's final line. The artifact publish path streams the same way. Bundle mutation is split from reporting because the workers still borrow the bundle while results arrive. Knit-Group: kg_20260829_6a92a7 Knit-Bundle: stream-push-and-publish-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
This PR is part of Knit bundle
stream-push-and-publish-progress.See the other review objects in this bundle:
knit: stream push and publish progress (knit) #176 (this PR)Bundle id:
stream-push-and-publish-progressBundle title: stream push and publish progress