Skip to content

intermediate target merges branches (knit) - #171

Merged
marc-merino merged 2 commits into
mainfrom
knit/intermediate-target-merges-branches
Aug 25, 2026
Merged

intermediate target merges branches (knit)#171
marc-merino merged 2 commits into
mainfrom
knit/intermediate-target-merges-branches

Conversation

@marc-merino

@marc-merino marc-merino commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Knit Bundle

This PR is part of Knit bundle intermediate-target-merges-branches.

See the other review objects in this bundle:

Bundle id: intermediate-target-merges-branches
Bundle title: intermediate target merges branches

Ivaldi Desktop added 2 commits August 25, 2026 17:41
One rule for every explicit destination: intermediate = merge the feature
branches and leave the reviews open, terminal = merge the reviews and
archive. `knit land --target <branch>` is now an ad-hoc lane that sends
every changed repository to that one branch. Before, a non-terminal
`--target` retargeted and merged the reviews and then left the bundle open
with no way to finish it.

A bare `knit land` names no destination of its own and still merges each
review where it points; the dead-end warning stays for that case and for
hand-edited plans. The artifact path follows the same rule with
`--target ... --intermediate`. Deployment selection reads each merge
step's destination from the step, so repositories without a review keep
their `landing.targets.<branch>.deployments`.

Knit-Group: kg_20260825_486e3a
Knit-Bundle: intermediate-target-merges-branches
…get-merges-branches

# Conflicts:
#	tests/land.rs
@marc-merino
marc-merino merged commit dc8f004 into main Aug 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant