Skip to content

Update nested OWNERS to use steering-committee alias instead of TOC - #1798

Merged
knative-prow[bot] merged 2 commits into
mainfrom
update-owners-sc-alias
Oct 15, 2026
Merged

Update nested OWNERS to use steering-committee alias instead of TOC#1798
knative-prow[bot] merged 2 commits into
mainfrom
update-owners-sc-alias

Conversation

@dsimansk

@dsimansk dsimansk commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Migrate the deprecated technical-oversight-committee (TOC) owner alias to steering-committee (SC) across the nested OWNERS files. The root OWNERS and OWNERS_ALIASES are unchanged.

 .github/OWNERS                | 4 ++--
 groups/OWNERS                 | 2 +-
 groups/wg-productivity/OWNERS | 2 +-
 label_sync/OWNERS             | 4 ++--
 mechanics/OWNERS              | 4 ++--
 peribolos/OWNERS              | 4 ++--
 working-groups/OWNERS         | 2 --
 7 files changed, 10 insertions(+), 12 deletions(-)

--- a/.github/OWNERS
+++ b/.github/OWNERS
 approvers:
-- technical-oversight-committee
+- steering-committee
 
 reviewers:
-- technical-oversight-committee
+- steering-committee

--- a/groups/OWNERS
+++ b/groups/OWNERS
 approvers:
-- technical-oversight-committee
+- steering-committee
 - productivity-wg-leads

--- a/groups/wg-productivity/OWNERS
+++ b/groups/wg-productivity/OWNERS
 approvers:
+- steering-committee
 - productivity-writers
-- technical-oversight-committee

--- a/label_sync/OWNERS
+++ b/label_sync/OWNERS
 approvers:
-- technical-oversight-committee
+- steering-committee
 - productivity-writers
 reviewers:
-- technical-oversight-committee
+- steering-committee
 - productivity-writers

--- a/mechanics/OWNERS
+++ b/mechanics/OWNERS
 approvers:
-- technical-oversight-committee
+- steering-committee
 
 reviewers:
-- technical-oversight-committee
+- steering-committee

--- a/peribolos/OWNERS
+++ b/peribolos/OWNERS
 approvers:
-- technical-oversight-committee
+- steering-committee
 
 reviewers:
-- technical-oversight-committee
+- steering-committee

--- a/working-groups/OWNERS
+++ b/working-groups/OWNERS
 approvers:
 - steering-committee
-- technical-oversight-committee
 reviewers:
 - steering-committee
-- technical-oversight-committee

/cc @knative/steering-committee

@dsimansk
Update nested OWNERS to use steering-committee alias instead of TOC
183dc3a 
Migrate the deprecated technical-oversight-committee owner alias to steering-committee across the nested OWNERS files (.github, groups, groups/wg-productivity, label_sync, mechanics, peribolos, working-groups).
@knative-prow
knative-prow Bot requested a review from a team October 13, 2026 20:00
@knative-prow

knative-prow Bot commented Oct 13, 2026

Copy link
Copy Markdown

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2026
@dsimansk

dsimansk commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

It's unecessary duplication of SC being in root-level OWNERS.
/hold

@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2026
aliok
aliok approved these changes Oct 13, 2026
View reviewed changes

@aliok aliok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2026
@aliok

aliok commented Oct 13, 2026

Copy link
Copy Markdown
Member

@cardil @upodroid wanna take a look at this one?

@dsimansk

dsimansk commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

I'd remove nested OWNERS that contains only SC as it's inherited from root level anyway. As a result we will have less files to check.

@knative-prow knative-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2026
@knative-prow

knative-prow Bot commented Oct 13, 2026

Copy link
Copy Markdown

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@knative-prow knative-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2026
@dsimansk

dsimansk commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@aliok @upodroid PTAL, I've removed files that only contained TOC or TOC+SC combination that is already inherited from root-level.

dsimansk
dsimansk commented Oct 13, 2026
View reviewed changes
Comment thread groups/OWNERS

approvers:
- technical-oversight-committee
- steering-committee

@dsimansk dsimansk Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even those are duplicates to root-level, but I'll leave it as an explicit reminder? :)

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2026
@knative-prow

knative-prow Bot commented Oct 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dsimansk, evankanderson, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [aliok,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk

dsimansk commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/unhold

@knative-prow knative-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2026
@knative-prow
knative-prow Bot merged commit ffd4e62 into main Oct 15, 2026
5 checks passed
@dprotaso
dprotaso deleted the update-owners-sc-alias branch October 30, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok aliok approved these changes
@evankanderson evankanderson evankanderson approved these changes
@upodroid upodroid upodroid approved these changes

Assignees

@aliok aliok

@evankanderson evankanderson

@upodroid upodroid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsimansk @aliok @evankanderson @upodroid