Skip to content

Added autocomplete input field for assigning bulk default user #3250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pandafy wants to merge 2 commits into
base: master
Choose a base branch
from
+64 −14
Open

Added autocomplete input field for assigning bulk default user #3250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dfe4be
Added autocomplete input field for assigning bulk default user
pandafy Jun 18, 2023
b7ff166
[requested-changes] Added modal for assigning default-tester
pandafy Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tcms/static/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,20 @@ $(() => {
window.markdownEditor = initSimpleMDE(this, uploadField)
})

$('.dropdown.dropdown-keep-open').on('hide.bs.dropdown', function (ev) {
// Disable automatic closing of dropdown menu.
// This is required for using typeahead fields in submenu options.
return false
})

$(document).on('click', function (ev) {
if (!$(ev.target).parents('.dropdown.dropdown-keep-open').length) {
// The target is not inside the dropdown element.
// Close open dropdowns
$('.dropdown.dropdown-keep-open.open').removeClass('open')
}
})

// for debugging in browser
window.jsonRPC = jsonRPC
})
44 changes: 40 additions & 4 deletions tcms/testplans/static/testplans/js/get.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,16 +539,52 @@ function toolbarEvents (testPlanId, permissions) {
return false
})

$('#default-tester-button').click(function (ev) {
$(this).parents('.dropdown').toggleClass('open')
$('input.user-field.typeahead').on('focusin', function () {
// Prevents sub-menu options from hidding when
// selecting typeahead suggestion.
$(this).parents('ul').css('display', 'block')
})

$('input.user-field.typeahead').typeahead({
minLength: 3,
highlight: true
}, {
name: 'default-tester-autocomplete',
// will display up to X results even if more were returned
limit: 100,
async: true,
display: function (element) {
return element.username
},
source: function (query, processSync, processAsync) {
jsonRPC('User.filter', { username__icontains: query }, function (data) {
Copy link
Copy Markdown
Member

@atodorov atodorov Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: User.filter depends on having the auth.view_user permission which currently silently prints errors in the console if the permission is not granted.

I'm not sure if/how we want to inform users that their auto-complete searches may not work because they are missing the permission.

Maybe we should default to the old implementation if permission isn't granted and allow auto-complete only when it is.

return processAsync(data)
})
}
})

$('#default-tester-button').click(function () {
addDefaultTester()
})

$('#id_tags').keyup(function (event) {
if (event.keyCode === 13) {
addDefaultTester()
};
})

function addDefaultTester () {
$('#default-tester-button').parents('.dropdown').removeClass('open')
// Closes the sub-menu option that contains input field
$('#default-tester-button').parents('ul').css('display', '')
const selectedCases = getSelectedTestCases()

if (!selectedCases.length) {
alert($('#test_plan_pk').data('trans-no-testcases-selected'))
return false
}

const emailOrUsername = window.prompt($('#test_plan_pk').data('trans-username-email-prompt'))
const emailOrUsername = $('input.typeahead.user-field.tt-input').val()

if (!emailOrUsername) {
return false
Expand All @@ -558,7 +594,7 @@ function toolbarEvents (testPlanId, permissions) {
testPlanId, permissions)

return false
})
}

$('#bulk-reviewer-button').click(function (ev) {
$(this).parents('.dropdown').toggleClass('open')
Expand Down
16 changes: 11 additions & 5 deletions tcms/testplans/templates/testplans/get.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ <h2 class="card-pf-title">
<div class="col-sm-12 toolbar-pf-filter" style="padding-left:0">
<form class="toolbar-pf-actions">
<div class="form-group" style="padding-left:10px; padding-right:0; border:0">
<div class="dropdown btn-group">
<div class="dropdown btn-group dropdown-keep-open" data-bs-auto-close="false">
<button class="btn btn-link dropdown-toggle"
type="button" id="testCaseActions"
data-toggle="dropdown" aria-haspopup="true" aria-expanded="true">
Expand Down Expand Up @@ -168,14 +168,20 @@ <h2 class="card-pf-title">
{% endfor %}
</ul>
</li>

<li>
<a id="default-tester-button" href="#">
<li class="dropdown-submenu">
<a href="#">
<span class="fa fa-search"></span>
{% trans 'Default tester' %}
</a>
<ul class="dropdown-menu dropdown-menu-right js-toolbar-default-tester" style="min-width: 220px;padding: 5px;">
<div style="display: inline-block;">
<input type="text" class="form-control typeahead user-field">
</div>
<button class="btn btn-default" title="Apply" style="margin-left: 5px;" id="default-tester-button">
<span class="fa fa-check"></span>
</button>
</ul>
</li>

<li>
<a id="bulk-reviewer-button" href="#">
<span class="fa fa-history"></span>
Expand Down