Repository navigation
feat(windows): complete release candidate implementation - #5
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kiranreddi
marked this pull request as ready for review
August 1, 2026 06:18
Keep the release-candidate Windows implementation as the source of truth for app code, union website mobile padding selectors from both sides, restore --ui-test popup wiring from main, and align SettingsViewModel tests with the async JsonAppSettingsStore interface. Co-authored-by: Kiran <kiranreddi@users.noreply.github.com>
The merge kept the older Settings/Popup markup while code-behind still referenced SettingsScrollViewer and DiffTextBlock, breaking Windows CI. Restore the branded views from main and wire PopupBorder / automation names. Co-authored-by: Kiran <kiranreddi@users.noreply.github.com>
Code-behind references PopupBorder for HighContrast handling; add the x:Name so WPF codegen produces the field on windows-latest CI. Co-authored-by: Kiran <kiranreddi@users.noreply.github.com>
1 of 4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated verification
Release qualification still external
See
docs/WINDOWS-IMPLEMENTATION-STATUS.md. The interactive app/DPI matrix, real cloud-provider smoke tests, production signing certificate, signed install/update/rollback/repair/uninstall checks, Defender/SmartScreen validation, hosted signed download, and 10–20-person beta still require external Windows hardware, credentials, and release infrastructure. This PR intentionally does not fabricate those results.