feat: add metric implementation and address some suspected logic bugs. - #20
Open
aidanhall34 wants to merge 7 commits into
Open
feat: add metric implementation and address some suspected logic bugs.#20aidanhall34 wants to merge 7 commits into
aidanhall34 wants to merge 7 commits into
Conversation
Need to flesh out the bugs/spec drift with people in the office. Implemented metrics are working, but could use a clean up. Added in some infra bits around kafka setup/data production.
aidanhall34
marked this pull request as draft
July 20, 2026 10:06
added 2 commits
July 20, 2026 20:15
akaur13
marked this pull request as ready for review
July 22, 2026 00:49
aidanhall34
commented
Jul 22, 2026
aidanhall34
left a comment
aidanhall34
left a comment
Contributor
Author
There was a problem hiding this comment.
found the button!
aidanhall34
marked this pull request as draft
July 22, 2026 01:43
added 4 commits
August 17, 2026 10:15
The implementation was comparing all produced timestamps to UTC time. The spec says README.md#L136: A message requiring a delay is inserted into the database so that it can be published later. Before insertion, the queuing node compares the deadline to its local clock. The code was reading all timestamps as utc time. Also spent time optimizing the histogram bucket sizes to capture sub 100ms processing and queue latency times.
…ts and local time compare
akaur13
approved these changes
Aug 21, 2026
akaur13
marked this pull request as ready for review
August 21, 2026 00:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to flesh out the bugs/spec drift with people in the office.
Implemented metrics are working, but could use a clean up.
Added in some infra bits around kafka setup/data production.