Skip to content

Better Github detection #233

Open
Open

Description

@Lazerbeak12345

Is your feature request related to a problem? Please describe.
I use the ssh remote format for many of my cloned github repos.

An example of this format is:

git clone git@github.com:kefranabg/readme-md-generator.git

As you can see in this function below...

/**
* Check if repository is a Github repository
*
* @param {string} repositoryUrl
*/
const isGithubRepository = repositoryUrl =>
!isNil(repositoryUrl) && repositoryUrl.includes(GITHUB_URL)

Where GITHUB_URL is defined as

const GITHUB_URL = 'https://github.com/'

The check for if a local project is a github project clone only handles git-over-https.

Describe the solution you'd like
An expansion to treat git-over-ssh on the github url as the same as the equivalent git-over-https

Describe alternatives you've considered
Unsure.

Additional context
...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions