fix(e2e): correct BasicSearchFilterParameter field and missing filename in descriptive metadata update#3670
Open
luis100 wants to merge 3 commits into
Open
fix(e2e): correct BasicSearchFilterParameter field and missing filename in descriptive metadata update#3670luis100 wants to merge 3 commits into
luis100 wants to merge 3 commits into
Conversation
…lename in descriptive metadata update - BasicSearchFilterParameter: use RODA's catch-all Solr field "search" instead of "*" which is not a valid Solr field name (was causing 400) - updateDescriptiveMetadata: add "filename" to request body using the metadata id, as AIPService.updateDescriptiveMetadataFile() uses request.getFilename() as the descriptiveMetadataId for the storage path (null filename was causing 500) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchAips_withBasicSearchFilter:BasicSearchFilterParameterwas usingname: \"*\"which is not a valid Solr field. Changed toname: \"search\"— RODA's catch-all Solr field (RodaConstants.INDEX_SEARCH), consistent with how the UI constructs basic searches.updateDescriptiveMetadata:AIPService.updateDescriptiveMetadataFile()usesrequest.getFilename()as thedescriptiveMetadataIdfor the storage path. The request body was missingfilename, causing a null storage path. Added\"filename\": aipMetadataIdto the request (the metadataidfrom the info endpoint IS the storage filename, e.g.metadata.xml).Test plan
mvn test -pl roda-api-tests -Pe2e— all 19 tests should pass (0 failures)🤖 Generated with Claude Code