Add roda-api-tests E2E module and fix IndexService NPE#3669
Closed
luis100 wants to merge 18 commits into
Closed
Conversation
correct DetailsPanelLogEntry location package.
Co-authored-by: Luis Faria <lfaria@keep.pt>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-ORGPOSTGRESQL-16321668 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-16109615 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-16109618 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Introduces a new Maven module (roda-api-tests, activated via -Pe2e) that runs black-box API tests against a live RODA stack managed by Testcontainers (ComposeContainer). Tests use REST Assured against OpenAPI-generated model POJOs and cover authentication, AIP count, AIP find, and configuration endpoints. Readiness uses a two-phase approach: Testcontainers polls /actuator/health until "status":"UP", then a custom loop polls /members/users/authenticated until LDAP auth is operational. Also fixes a NullPointerException in IndexService.count() when CountRequest.getFilter() is null (changed toString() to String.valueOf()). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dosubot
Bot
added
the
size:XL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roda-api-testsMaven module (activated via-Pe2e) with black-box E2E API tests that spin up the full RODA stack via Testcontainers (ComposeContainer) and exercise the REST API with REST Assureddeploys/standalone/docker-compose-e2e.yaml— the compose file used by the test infrastructureNullPointerExceptioninIndexService.count()whenCountRequest.getFilter()is null (changed.toString()toString.valueOf())New tests (AipApiTest)
getAuthenticatedUser_returnsAdminUserGET /members/users/authenticatedcountAips_withAllFilter_returns200AndNonNegativeCountPOST /aips/countfindAips_withAllFilter_returns200AndValidIndexResultPOST /aips/findgetAipConfigurationTypes_returns200GET /aips/configuration/typesReadiness strategy
Testcontainers polls
/actuator/healthuntil"status":"UP"(covers RODA, Solr, PostgreSQL), then a secondary loop pollsGET /members/users/authenticateduntil LDAP auth is operational (LDAP initialization lags the actuator signal by ~10 s).How to run
Test plan
keeps/roda:developmentimageIndexServiceNPE fix verified:POST /aips/countno longer returns 500 when filter is null🤖 Generated with Claude Code