chore(ci): simplify npm cache configuration in check-links workflow#1757
Open
linkvt wants to merge 1 commit intokedacore:mainfrom
Open
chore(ci): simplify npm cache configuration in check-links workflow#1757linkvt wants to merge 1 commit intokedacore:mainfrom
linkvt wants to merge 1 commit intokedacore:mainfrom
Conversation
The custom cache-hash step extracted a subset of package.json fields into a temporary file for the cache key. Using the default package-lock.json is simpler and more reliable. Changes: - Remove "Create NPM cache-hash input file" step - Remove custom cache-dependency-path from setup-node Signed-off-by: Vincent Link <vlink@redhat.com>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the check-links GitHub Actions workflow by relying on the default npm lockfile (package-lock.json) for cache key generation instead of generating a custom cache-hash input file.
Changes:
- Removed the “Create NPM cache-hash input file” step (and its temporary
tmp/file usage). - Removed the custom
cache-dependency-pathoverride fromactions/setup-node, allowing it to use the default lockfile behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom cache-hash step extracted a subset of package.json fields into a temporary file for the cache key. Using the default package-lock.json is simpler.
Changes:
Checklist