Skip to content

Deploy with KEDA_HTTP_TLS_CIPHER_LIST, KEDA_SERVICE_MIN_TLS_VERSION and KEDA_SERVICE_TLS_CIPHER_LIST env vars#842

Open
joelsmith wants to merge 1 commit intokedacore:mainfrom
joelsmith:main
Open

Deploy with KEDA_HTTP_TLS_CIPHER_LIST, KEDA_SERVICE_MIN_TLS_VERSION and KEDA_SERVICE_TLS_CIPHER_LIST env vars#842
joelsmith wants to merge 1 commit intokedacore:mainfrom
joelsmith:main

Conversation

@joelsmith
Copy link
Copy Markdown
Contributor

Settings for kedacore/keda#7617

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin
  • README is updated with new configuration values
  • A PR is opened to update KEDA core

@joelsmith joelsmith requested review from a team as code owners April 8, 2026 07:22
@joelsmith joelsmith changed the title Deploy with KEDA_HTTP_TLS_CIPHER_LIST, KEDA_GRPC_MIN_TLS_VERSION and KEDA_GRPC_TLS_CIPHER_LIST env vars Deploy with KEDA_HTTP_TLS_CIPHER_LIST, KEDA_SERVICE_MIN_TLS_VERSION and KEDA_SERVICE_TLS_CIPHER_LIST env vars Apr 13, 2026
@wozniakjan wozniakjan mentioned this pull request Apr 22, 2026
22 tasks
Copy link
Copy Markdown
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR check failure is imho related to the changes

Run helm install keda ./keda/ --namespace keda --values test-values.yaml --wait
  helm install keda ./keda/ --namespace keda --values test-values.yaml --wait
  shell: /usr/bin/bash -e {0}
Error: INSTALLATION FAILED: Service "keda-operator-metrics-apiserver" is invalid: [spec.ports[0].port: Invalid value: 0: must be between 1 and 65535, inclusive, spec.ports[0].targetPort: Invalid value: 0: must be between 1 and 65535, inclusive]

Deployment.apps "keda-operator-metrics-apiserver" is invalid: [spec.template.spec.containers[0].ports[0].containerPort: Required value, spec.template.spec.containers[0].livenessProbe.httpGet.port: Invalid value: 0: must be between 1 and 65535, inclusive, spec.template.spec.containers[0].readinessProbe.httpGet.port: Invalid value: 0: must be between 1 and 65535, inclusive]

Comment thread keda/values.yaml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Helm chart to expose new TLS configuration options (min TLS version and cipher suite list) via values and to pass them to KEDA components as environment variables, aligning with kedacore/keda#7617.

Changes:

  • Add new values for HTTP TLS cipher lists and service-side TLS settings.
  • Inject KEDA_HTTP_TLS_CIPHER_LIST, KEDA_SERVICE_MIN_TLS_VERSION, and KEDA_SERVICE_TLS_CIPHER_LIST into the manager and metrics-server Deployments.
  • Document the new values in the chart README.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.

File Description
keda/values.yaml Adds TLS-related values (but currently introduces a duplicate top-level service: key).
keda/templates/metrics-server/deployment.yaml Passes new TLS env vars to the metrics server container.
keda/templates/manager/deployment.yaml Passes new TLS env vars to the manager/operator container.
keda/README.md Documents newly added configuration values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread keda/README.md Outdated
Comment thread keda/README.md Outdated
Comment thread keda/values.yaml Outdated
Comment thread keda/templates/metrics-server/deployment.yaml Outdated
Comment thread keda/templates/manager/deployment.yaml Outdated
Comment thread keda/values.yaml Outdated
Comment thread keda/README.md Outdated
Comment thread keda/values.yaml Outdated
Comment thread keda/README.md Outdated
Comment thread keda/README.md Outdated
…nd KEDA_SERVICE_TLS_CIPHER_LIST env vars

Signed-off-by: Joel Smith <joelsmith@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants