add change in trigger authentication CRD for hashiCorpVault#774
Open
raviand wants to merge 1 commit intokedacore:mainfrom
Open
add change in trigger authentication CRD for hashiCorpVault#774raviand wants to merge 1 commit intokedacore:mainfrom
raviand wants to merge 1 commit intokedacore:mainfrom
Conversation
Signed-off-by: Ramiro Videla <raviand86@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Added a new field, tokenSecretRef, to the HashiCorp Vault credentials configuration.
This new field allows users to specify a Kubernetes secret containing the Vault token.
The existing token string field will be used as a fallback if tokenSecretRef is not provided.
Why This Is Important
Previously, the HashiCorp Vault token had to be provided directly as a string in the KEDA configuration. This is not a recommended security practice for production environments, as it can expose sensitive information.
This change introduces a more secure way to manage the token by leveraging Kubernetes secrets. This aligns with best practices for handling credentials within a Kubernetes cluster.
How to Use It
Users can now configure their trigger with either the existing token field or the new tokenSecret field. For example:
In the example above, secret-name and secret-key point to the secret containing the token.
KEDA core PR change: kedacore/keda#6996
Checklist
Fixes #