Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TFTP read and write requests can carry RFC 2347 option/value pairs after the filename and mode. Decoding currently drops those bytes, so repacking a captured request silently removes parameters such as
blksizeandtsize.Retain the suffix in
TFTP.data, preserving the existing filename/mode API and allowing requests to be edited and repacked without losing their options.Validation: the new regression fails on unchanged master and passes with the fix. It covers read/write requests, single/multiple options and filename edits. All 454 tests pass (99% coverage); required syntax/undefined-name lint, changed-file full lint and compileall pass on Python 3.12.3. The existing optionless, DATA, ERR and unknown-opcode tests pass. This is packet-fixture testing; no external TFTP server was exercised. Python 2.7 and the older CI interpreter matrix were unavailable locally.