Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoded resource records keep their original wire RDATA. Reusing it while packing a new message leaves compressed names pointing at old offsets. A four-answer reply reproduces an
Invalid label lengtherror after an unchanged decode/encode cycle; inserting a question can instead silently changemail.google.comtomail.google.example.net.Rebuild decoded NS/CNAME/PTR/SOA/MX data against the current compression table. Keep caller-supplied raw RDATA and explicit overrides on decoded records. MX repacking accepts the existing tuple-valued decoded preference without changing that API.
Fixes #443.
Validation on Linux/Python 3.12: regressions reproduce the old behavior;
python -m pytest dpkt --cov=dpkt -qpasses all 456 tests (99% coverage). The workflow's blocking flake8 selection andgit diff --checkpass. Tests cover unchanged multi-answer round trips, relocated records, all five name-bearing types, and raw-data compatibility. Packet fixtures only; no live DNS deployment was tested.