Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #681.
Readercurrently applies the first interface's timestamp resolution and offset to every packet. A capture containing microsecond and nanosecond interfaces therefore produces incorrect timestamps for the later interface.Register each interface's clock and use the EPB/PB interface ID when decoding timestamps. Reset this table at section boundaries and read the new section's byte order before interpreting block lengths. Keep
idb,snaplen,dloffanddatalink()describing the first interface. Since the pypcap-compatible API exposes only one link type, explicitly reject incompatible link types; unknown interface IDs also raiseValueError.Regression tests cover interleaved interfaces, decimal and binary resolutions, signed offsets, high timestamp bits, both packet block formats, mixed-endian sections and invalid interface references. All four new tests fail against the original implementation.
Validation:
UniversalReaderalso reads it correctly.Other Python versions and operating systems were not tested locally. Simple Packet Blocks remain ignored as before; the writer is unchanged.
AI assistance was used for investigation, implementation and validation.