fix(cli): reject non-finite and overflowing timeouts - #38
Open
rupayon123 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Numeric
--timeoutvalues are parsed as floating-point seconds and converted totime.Duration.NaNcurrently becomes zero on arm64, silently disabling the timeout, while infinity and overflowing numbers are accepted with architecture-dependent conversion results.Reject non-finite values and seconds whose nanosecond value is outside the duration range before conversion. Preserve zero, fractional seconds, ordinary seconds and Go duration strings.
Validation
Six new cases failed before the fix:
NaN,Inf,+Inf,1e100,9223372037and9223372036.854776. The regression also checks negative infinity rejection and valid zero/fractional/large finite/duration-string inputs.After the fix:
env -u NO_COLOR go test ./...,go vet ./...,go build ./cmd/kurl, formatting andgit diff --checkpass. The default local environment setsNO_COLOR=1, which causes two existing printer color assertions to fail; the suite passes with that variable unset.golangci-lintis unavailable locally. Remote CI is separate and will be checked on the pushed head.Prepared with AI assistance.