Repository navigation
Bump multus to 4.3.1 - #319
Merged
Merged
Conversation
multus-cni v4.3.1 requires go >= 1.26.0. Bump the go directive, update the pinned toolchain to go1.26.9, and align the go-version in the CI workflows and the builder image.
multus-cni v4.3.1 depends on k8s.io 0.36.2 modules. Bump api, apimachinery, client-go, and kubelet, along with the transitive dependencies forced by minimal version selection (go-restful, go-difflib, x/time, protobuf, kube-openapi, k8s/utils, structured-merge-diff) and the vendored sources.
Bump multus-cni from v4.3.0 to v4.3.1. Changes in the vendored API surface: - new MultusReadyAPIEndpoint (/readyz) - WaitUntilAPIReady now polls /readyz instead of /healthz - new logging.Warningf helper
Go 1.26 enables stricter printf vet checks that reject non-constant format strings. Wrap the pre-formatted event messages with "%s".
cri-api v0.36.2 added StreamPodSandboxes, StreamContainers, StreamContainerStats, StreamPodSandboxStats, and StreamPodSandboxMetrics to the RuntimeServiceClient interface (KEP-5825). Add stub implementations so the fake client keeps satisfying the interface. Signed-off-by: Or Shoval <oshoval@redhat.com>
|
Important Review skippedToo many files! This PR contains 686 files, which is 586 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
⛔ Files ignored due to path filters: 80
📒 Files selected for processing: 686
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
thanks, can you please create new tag so we consume it on CNAO ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In addition bump go to 1.26, and libs as required by the multus bump.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer (optional):
Possible follow-up:
Since multus v4.3.1, the multus thick daemon exposes two endpoints over
its unix socket:
including during graceful shutdown. This is deliberate: CNI DEL
cleanup must still be able to proceed while the daemon is draining.
the daemon receives SIGTERM.
Our daemonset currently curls /healthz for both livenessProbe and
readinessProbe (templates/dynamic-networks-controller.yaml.j2).
Proposed change:
report NotReady, so kubectl wait / rollout status reflect reality and
the pod is removed from any Service endpoints before it goes away.
pod SIGKILLed during graceful shutdown, defeating the cleanup window
that /healthz exists to preserve.