Repository navigation
Conversation
Contributor
Author
|
The I added Verification:
Please review the added boundary-case coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JacksonSerializer.Root cause
JJWT supplies claims and headers to the serializer as
Map<String, ?>. Jackson therefore sees each value asObjectand does not apply type metadata configured on an interface or base type, so the@classproperty required by@JsonTypeInfois omitted.Changes
ObjectMapper, including nested maps, iterables, and object arrays.@JsonTypeInfoand custom deserialization.byte[]andchar[]map values.Testing
./mvnw -pl impl -am -Dtest=io.jsonwebtoken.CustomObjectDeserializationTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw -pl extensions/jackson -am test./mvnw -pl impl -am test./mvnw verify -Dgpg.skip=true./mvnw license:checkcould not run in the linked worktree because the license plugin's Git check reportedBare Repository has neither a working tree, nor an index.Coverage follow-up
testNestedMapValuesfor null map values, nested maps, iterables, and object arrays.JacksonSerializerTest: passed (14 tests).clover:setup testreactor run on JDK 17: passed.code-coverage,license-check, and the complete JDK 8/11/17/21/25 matrix: passed.Fixes #1065