Repository navigation
Remove Bootstrap styling dependency from ng-kit library - #150
Closed
pavankjadda wants to merge 1 commit into
Closed
pavankjadda wants to merge 1 commit into
pavankjadda wants to merge 1 commit into
Conversation
Migration: Spinner now renders an indeterminate Material progress spinner; bootstrapSpinner remains accepted but has no effect. Existing button, alert, and dialog class names remain. The library supplies CSS for these classes, so global button utility names can affect other elements. Apps using cascade layers should place ng-kit before utilities. Without Bootstrap, alert colors use the Bootstrap 5 light palette as fallback; dark mode needs app theme overrides.
✅ Deploy Preview for ng-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ng-kitcascade layer. Existing button, alert, spinner, and dialog class names remain; the demo still imports Bootstrap 5 for its layout.bootstrapSpinneras a deprecated, no-op input so existing bindings compile.Validation
pnpm run test: 114 passed.pnpm run lint: 0 errors, 31 existing warnings.pnpm run buildandpnpm run build:demo: passed.Migration notes
[bootstrapSpinner]is still accepted but has no effect..btn,.btn-primary, and.gap-1, so those selectors can also affect unrelated elements using the same names.ng-kitbefore utility layers so utility rules retain precedence.