chore: ban panic/expect/unwrap in production code via clippy - #123
Merged
Merged
Conversation
Add workspace-level clippy lints (unwrap_used, expect_used, panic, todo, unimplemented, unreachable) enforced as errors in core, cli and sdk, with test-code exemptions via clippy.toml. Replace all violating call sites with proper error propagation or logged fallbacks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds workspace-level clippy lints denying
unwrap_used,expect_used,panic,todo,unimplemented, andunreachable, enforced as compile errors in thecore,cli, andsdkcrates (e2e-tests and playground are intentionally excluded). A rootclippy.tomlexempts#[cfg(test)]code so unit tests stay idiomatic. All ~40 violating call sites are replaced with proper error propagation or logged fallbacks — notably theCacheValueconverters now degrade to a cache miss instead of killing the process, relayer wallet creation rolls back its DB transaction on failure, and transaction-replace validates blob hex before mutating state. Verified withcargo clippy --all-targets(clean),cargo fmt --check, workspace-widecargo check, and passing unit tests.🤖 Generated with Claude Code