Skip to content
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
0f834fb
Refactor matAlgo14xDs
dvd101x Dec 9, 2025
c9d57a1
Included an algorithm for Array and scalars
dvd101x Dec 9, 2025
d273182
fixed name of the exporter function
dvd101x Dec 9, 2025
fb35b55
Merge branch 'develop' into jagged-arrays
dvd101x Dec 9, 2025
af646a8
Fixed missing variable
dvd101x Dec 12, 2025
57c4cb2
Added tests and removed useMatrixForArrayScalar.js
dvd101x Dec 14, 2025
8e58d2b
added more tests
dvd101x Dec 14, 2025
cdceb79
Added documentation
dvd101x Dec 15, 2025
d67b73d
Added benchmarks
dvd101x Dec 17, 2025
a720b66
Fixed comment to allow for non-rectangular arrays
dvd101x Dec 17, 2025
4a215ed
Define terminology used for nested arrays.
dvd101x Dec 20, 2025
4bdb5ca
Documentation fixes for non-rectangular arrays
dvd101x Dec 20, 2025
8c6c47d
Removed concat and other dependancies from factory functions
dvd101x Dec 20, 2025
47fc7aa
Merge branch 'develop' into jagged-arrays
dvd101x Dec 20, 2025
2130ba6
Merge branch 'develop' into jagged-arrays
dvd101x Jan 8, 2026
0c08fd0
Merge branch 'develop' into jagged-arrays
dvd101x Jan 21, 2026
996a5e7
Merge branch 'develop' into jagged-arrays
dvd101x Feb 18, 2026
cbcb691
Include history of `add`
dvd101x Feb 24, 2026
b409734
Added `dotDivide` history
dvd101x Feb 24, 2026
dd37a16
Added `dotMultiply` history
dvd101x Feb 24, 2026
2ba17c4
Added history of `dotPow`
dvd101x Feb 24, 2026
7851c6c
Added history for `gcd`
dvd101x Feb 24, 2026
eeab295
Added history for `lcm`
dvd101x Feb 24, 2026
e353386
Added history for `mod`
dvd101x Feb 24, 2026
a5c7d8f
Added history for `nthRoot`
dvd101x Feb 24, 2026
471b9a0
Added history for `nthRoot`
dvd101x Feb 24, 2026
58fbad7
Added history for `subtract`
dvd101x Feb 24, 2026
19b3bc2
Added history for `bitAnd`
dvd101x Feb 24, 2026
6992600
Added history for `bitOr` and `bitXor`
dvd101x Feb 24, 2026
f8a0659
Added history to `leftShift`, `rightArithShift` and `rightLogShift`
dvd101x Feb 24, 2026
ac4bf47
Added history for `and`, `or` and `xor`
dvd101x Feb 24, 2026
ffd1e72
Added history of `compare`
dvd101x Feb 24, 2026
e565ada
History for `equal`
dvd101x Feb 24, 2026
76aab1a
History for `larger`
dvd101x Feb 24, 2026
e71bb52
History for `largerEq`
dvd101x Feb 24, 2026
1fab22a
history for `largerEq`
dvd101x Feb 24, 2026
1e62b6c
Add history to `smaller`
dvd101x Feb 24, 2026
4362b6e
History for `smallerEq`
dvd101x Feb 24, 2026
7a58f84
History for `unequal`
dvd101x Feb 24, 2026
c7119db
History for `atan2`
dvd101x Feb 24, 2026
f127054
History for `to`
dvd101x Feb 24, 2026
9c5e98b
Added some missing "`"
dvd101x Feb 24, 2026
a07bfa4
Format
dvd101x Feb 24, 2026
493de05
Changed description from "Iterates" to "Deeply iterates"
dvd101x Feb 24, 2026
0d4a91a
Merge branch 'develop' into jagged-arrays
gwhitney Mar 5, 2026
0563b85
chore: make History format consistent; add test per #3537.
gwhitney Mar 5, 2026
d3d6f0e
Merge branch 'develop' into jagged-arrays
dvd101x Mar 19, 2026
903dbdc
Add test for `optimizeCallbak`. Included unary info for `map`
dvd101x Mar 21, 2026
daf597e
added test for `optimizeCallback
dvd101x Mar 21, 2026
88e1aa7
added more tests to `optimizeCallback`
dvd101x Mar 21, 2026
b520031
Restored capability to map non unary functions.
dvd101x Mar 29, 2026
f260f3c
Added tests to optimize callback findFirst
dvd101x Mar 30, 2026
c25a0ef
Fix tests for optimize callback
dvd101x Mar 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 2 additions & 37 deletions src/type/matrix/utils/matAlgo14xDs.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { factory } from '../../../utils/factory.js'
import { clone } from '../../../utils/object.js'

const name = 'matAlgo14xDs'
const dependencies = ['typed']
Expand All @@ -21,11 +20,6 @@ export const createMatAlgo14xDs = /* #__PURE__ */ factory(name, dependencies, ({
* https://github.com/josdejong/mathjs/pull/346#issuecomment-97659042
*/
return function matAlgo14xDs (a, b, callback, inverse) {
// a arrays
const adata = a._data
const asize = a._size
const adt = a._datatype

// datatype
let dt
// callback signature to use
Expand All @@ -34,42 +28,13 @@ export const createMatAlgo14xDs = /* #__PURE__ */ factory(name, dependencies, ({
// process data types
if (typeof adt === 'string') {
// datatype
Comment thread
gwhitney marked this conversation as resolved.
Outdated
dt = adt
dt = a._datatype
// convert b to the same datatype
b = typed.convert(b, dt)
// callback
cf = typed.find(callback, [dt, dt])
}
Comment thread
gwhitney marked this conversation as resolved.

// populate cdata, iterate through dimensions
const cdata = asize.length > 0 ? _iterate(cf, 0, asize, asize[0], adata, b, inverse) : []

// c matrix
return a.createDenseMatrix({
data: cdata,
size: clone(asize),
datatype: dt
})
}

// recursive function
function _iterate (f, level, s, n, av, bv, inverse) {
// initialize array for this level
const cv = []
// check we reach the last level
if (level === s.length - 1) {
// loop arrays in last level
for (let i = 0; i < n; i++) {
// invoke callback and store value
cv[i] = inverse ? f(bv, av[i]) : f(av[i], bv)
}
} else {
// iterate current level
for (let j = 0; j < n; j++) {
// iterate next level
cv[j] = _iterate(f, level + 1, s, s[level + 1], av[j], bv, inverse)
}
}
return cv
return inverse ? a.map(v => cf(b, v)) : a.map(v => cf(v, b))
}
})
26 changes: 26 additions & 0 deletions src/type/matrix/utils/matAlgo15xAs.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { factory } from '../../../utils/factory.js'
import { deepMap as map } from '../../../utils/array.js'

const name = 'matAlgo15xAs'
const dependencies = []

export const createMatAlgo15xAs = /* #__PURE__ */ factory(name, dependencies, () => {
/**
* Iterates over Array items and invokes the callback function f(Aij..z, b).
* Callback function invoked MxN times.
Comment thread
gwhitney marked this conversation as resolved.
Outdated
*
* C(i,j,...z) = f(Aij..z, b)
*
* @param {Array} a The Array instance (A)
* @param {Scalar} b The Scalar value
* @param {Function} cf The f(Aij..z,b) operation to invoke
* @param {boolean} inverse A true value indicates callback should be invoked f(b,Aij..z)
*
* @return {Array} Array (C)
*
* https://github.com/josdejong/mathjs/pull/346#issuecomment-97659042
*/
return function matAlgo15xAs (a, b, cf, inverse) {
return inverse ? map(a, v => cf(b, v)) : map(a, v => cf(v, b))
Comment thread
gwhitney marked this conversation as resolved.
Outdated
}
})
10 changes: 6 additions & 4 deletions src/type/matrix/utils/matrixAlgorithmSuite.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { factory } from '../../../utils/factory.js'
import { extend } from '../../../utils/object.js'
import { createMatAlgo13xDD } from './matAlgo13xDD.js'
import { createMatAlgo14xDs } from './matAlgo14xDs.js'
import { createMatAlgo15xAs } from './matAlgo15xAs.js'
import { broadcast } from './broadcast.js'

const name = 'matrixAlgorithmSuite'
Expand All @@ -11,6 +12,7 @@ export const createMatrixAlgorithmSuite = /* #__PURE__ */ factory(
name, dependencies, ({ typed, matrix }) => {
const matAlgo13xDD = createMatAlgo13xDD({ typed })
const matAlgo14xDs = createMatAlgo14xDs({ typed })
const matAlgo15xAs = createMatAlgo15xAs()

/**
* Return a signatures object with the usual boilerplate of
Expand Down Expand Up @@ -115,9 +117,9 @@ export const createMatrixAlgorithmSuite = /* #__PURE__ */ factory(
matrixSignatures[scalar + ', DenseMatrix'] =
(x, y) => matAlgo14xDs(y, x, elop, true)
matrixSignatures['Array,' + scalar] =
(x, y) => matAlgo14xDs(matrix(x), y, elop, false).valueOf()
(x, y) => matAlgo15xAs(x, y, elop, false)
matrixSignatures[scalar + ', Array'] =
(x, y) => matAlgo14xDs(matrix(y), x, elop, true).valueOf()
(x, y) => matAlgo15xAs(y, x, elop, true)
} else {
matrixSignatures['DenseMatrix,' + scalar] =
typed.referToSelf(self => (x, y) => {
Expand All @@ -129,11 +131,11 @@ export const createMatrixAlgorithmSuite = /* #__PURE__ */ factory(
})
matrixSignatures['Array,' + scalar] =
typed.referToSelf(self => (x, y) => {
return matAlgo14xDs(matrix(x), y, self, false).valueOf()
return matAlgo15xAs(x, y, self, false)
})
matrixSignatures[scalar + ', Array'] =
typed.referToSelf(self => (x, y) => {
return matAlgo14xDs(matrix(y), x, self, true).valueOf()
return matAlgo15xAs(y, x, self, true)
})
}
}
Expand Down