fix(web): ignore log catch-up replay frames#535
Open
metyatech wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Task, workflow run, and PR review log views load persisted history through REST and also keep a WebSocket open for live log frames. The WebSocket endpoints replay recent log rows with
catchUp: trueon connect/reconnect so clients do not miss events.Those hooks were treating catch-up replay frames like normal live log frames after REST history had already loaded. On reconnect, the same recent log rows could therefore be appended again in the browser, making the log viewer show duplicate entries even though the persisted REST/DB history was not duplicated.
Session logs already avoid this by treating REST history as canonical and ignoring
catchUpWebSocket frames. This PR applies the same policy to the other log hooks.Summary
catchUpreplay frames in task, workflow run, and PR review log hooks.Verification
pnpm --filter @optio/web test -- src/hooks/use-logs.test.ts src/hooks/use-workflow-run-logs.test.ts src/hooks/use-pr-review-logs.test.tspnpm --filter @optio/web typecheckpnpm format:checkpnpm turbo testcompleted successfully