Skip to content

feature/Repeat list heading on new page#472

Open
Fernando-hub527 wants to merge 17 commits into
johnfercher:masterfrom
Fernando-hub527:repeat_list_heading
Open

feature/Repeat list heading on new page#472
Fernando-hub527 wants to merge 17 commits into
johnfercher:masterfrom
Fernando-hub527:repeat_list_heading

Conversation

@Fernando-hub527

Copy link
Copy Markdown
Collaborator

Description
This feature allows the creation of lists with a fixed header through a method available in the list component. This method receives an instance of Maroto and uses this instance to add the list to the PDF with the fixed header.

Related Issue
#130

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@codecov

codecov Bot commented Aug 30, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.27%. Comparing base (da3191b) to head (232c2f0).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   87.09%   87.27%   +0.19%     
==========================================
  Files          61       62       +1     
  Lines        2331     2364      +33     
==========================================
+ Hits         2030     2063      +33     
  Misses        268      268              
  Partials       33       33              
Flag Coverage Δ
unittests 87.27% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fernando-hub527

Copy link
Copy Markdown
Collaborator Author

@johnfercher conflicts fixed

@maddie

maddie commented May 20, 2025

Copy link
Copy Markdown

Will this PR be merged any time soon?

@dennisj86

Copy link
Copy Markdown

Awesome Job! But please, if possible, merge this feature @johnfercher .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants