feature/Repeat list heading on new page#472
Open
Fernando-hub527 wants to merge 17 commits into
Open
Conversation
Provide method that returns how many lines fit on the current page Provide method to add a new page
Make list creation easier
Add a method to generate the list with fixed header Allow the configuration of minimum rows per page
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 87.09% 87.27% +0.19%
==========================================
Files 61 62 +1
Lines 2331 2364 +33
==========================================
+ Hits 2030 2063 +33
Misses 268 268
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
remove jsons from tests that are not used
Add settings to line before getting height
Collaborator
Author
|
@johnfercher conflicts fixed |
|
Will this PR be merged any time soon? |
|
Awesome Job! But please, if possible, merge this feature @johnfercher . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This feature allows the creation of lists with a fixed header through a method available in the list component. This method receives an instance of Maroto and uses this instance to add the list to the PDF with the fixed header.
Related Issue
#130
Checklist
func (<first letter of struct> *struct) method() {}name style.when,shouldnaming pattern.m := mocks.NewConstructor(t).m.EXPECT().MethodName()method to mock methods.example_test.go.make dodwith none issues pointed out bygolangci-lint