Skip to content

dev: add mise config#7371

Merged
glehmann merged 1 commit into
jj-vcs:mainfrom
glehmann:gln/mise-config-tovo
Sep 4, 2025
Merged

dev: add mise config#7371
glehmann merged 1 commit into
jj-vcs:mainfrom
glehmann:gln/mise-config-tovo

Conversation

@glehmann
Copy link
Copy Markdown
Member

@glehmann glehmann commented Aug 27, 2025

This is a continuation of #6081

I've tried to use the task hierarchy proposed by @arxanas in #6081 (comment) and used the [vars] to define the tool versions in the tasks.
The tools are only declared in each task in order to be able to build the docs without installing the rust toolchain for example.

There are still a few things that could be better:

  • mise run 'check:*' output is completely flooded by the nextest output when using the recommended cargo insta test --test-runner nextest, and it becomes difficult to find the output of the other failed checks. Moreover, the check outputs are losing the coloring.
  • I'm not sure how to name the tasks using bacon

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@glehmann glehmann requested a review from a team as a code owner August 27, 2025 20:24
@jennings
Copy link
Copy Markdown
Contributor

nit: Since mise supports it, could we put the config in .config/mise.toml to avoid more clutter in the root of the repo?

@glehmann
Copy link
Copy Markdown
Member Author

nit: Since mise supports it, could we put the config in .config/mise.toml to avoid more clutter in the root of the repo?

Sure, good point. I'll do it tomorrow.

@ilyagr
Copy link
Copy Markdown
Contributor

ilyagr commented Aug 27, 2025

Cc @neongreen if Emily is interested.

Comment thread mise.toml Outdated
Comment thread Cargo.toml
@glehmann glehmann force-pushed the gln/mise-config-tovo branch 2 times, most recently from 3d1f90a to dc57427 Compare August 28, 2025 16:34
@glehmann
Copy link
Copy Markdown
Member Author

I've used nextest's --status-level=fail to mitigate the lisibility problem when running mise run "check:*".
I like it better this way also when running just the tests with nextest. It might not be to everyone's taste, though. Any opinion?

Comment thread .config/mise.toml
Comment thread .config/mise.toml Outdated
Comment thread .config/mise.toml
@glehmann glehmann force-pushed the gln/mise-config-tovo branch from dc57427 to 110de92 Compare August 29, 2025 19:29
Comment thread docs/contributing.md Outdated
@glehmann glehmann force-pushed the gln/mise-config-tovo branch 3 times, most recently from fe34c26 to 56db29a Compare August 31, 2025 12:40
Comment thread docs/contributing.md
The [vars] section is used to define the tool versions, and the tools
are only declared in each task in order to be able to run a task and
install only the required dependencies. This way

  mise build:docs

only install the docs dependencies, but not the rust toolchain.

The task are organized hierarchically, allowing to run all of the tasks
in a category, for example with

  mise run "check:*"

Some aliases for the most common tasks are defined in order to keep the
command line short and easy to type. For example use

  mise test squash

to run all the squash tests.

Co-authored-by: Emily <artyom@artyom.me>
@glehmann glehmann force-pushed the gln/mise-config-tovo branch from 56db29a to 60ea68d Compare September 2, 2025 18:49
Copy link
Copy Markdown
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gaetan!

@glehmann glehmann added this pull request to the merge queue Sep 4, 2025
Merged via the queue into jj-vcs:main with commit 1e1decb Sep 4, 2025
29 checks passed
@glehmann glehmann deleted the gln/mise-config-tovo branch September 4, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants