backout: partial reversion of 3f0703ca2cf#4627
Closed
thoughtpolice wants to merge 1 commit into
Closed
Conversation
All of these toml files already have a `[lints]` key, it just exited earlier on in the file and were missed. However, the occurrence of duplicate keys breaks TOML parsers that have stricter standard rules and reject these files (rather than merging the values). In particular, `tomllib` in Python 3.11 will reject these cargo files. Signed-off-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
force-pushed
the
aseipp/push-xpmqmlmuypzp
branch
from
afe6396 to
60e9677
Compare
thoughtpolice
changed the title
thoughtpolice
changed the title
thoughtpolice
changed the title
Contributor
|
This is missing a note to #1997 as an explainer in the description. Since it depends on |
martinvonz
reviewed
Oct 11, 2024
Member
martinvonz
left a comment
martinvonz
left a comment
There was a problem hiding this comment.
All of these toml files already have a
[lints]key, it just exited earlier on
in the file and were missed.
What do you mean by that? I don't see any existing [lints] tables elsewhere in these files. And what exited earlier?
Member
Author
|
Oh, you're right! OK, this was introduced on my end by a merge error, I think, and when I rebased off of my branch onto trunk, it applied the diff naturally (because my other branch introduced the lint keys separately.) I think this can be closed, but let me confirm that.... |
Member
Author
|
Yes, PEBKAC. Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these toml files already have a
[lints]key, it just exited earlier on in the file and were missed.However, the occurrence of duplicate keys breaks TOML parsers that have stricter standard rules and reject these files (rather than merging the values). In particular,
tomllibin Python 3.11 will reject these cargo files.Checklist
If applicable:
CHANGELOG.md