backend: add error variant for access denied, handle when diffing#3785
Merged
Conversation
martinvonz
force-pushed
the
push-ktvkyyrulzom
branch
5 times, most recently
from
9741dcc to
ae4f5f2
Compare
Contributor
PhilipMetzger
left a comment
PhilipMetzger
left a comment
There was a problem hiding this comment.
Some backends, like the one we have at Google, can restrict access to
certain files. For such files, if they return a regular
BackendError::ReadObject, then that will terminate iteration in many
cases (e.g. when diffing or listing files). This patch adds a new
error variant for them to return instead, plus handling of such errors
in diff output.
Happy to see this feature, as better ACLs is something I really want for the native backend.
martinvonz
force-pushed
the
push-ktvkyyrulzom
branch
from
ae4f5f2 to
e4d9e24
Compare
yuja
reviewed
May 30, 2024
PhilipMetzger
approved these changes
May 30, 2024
Contributor
PhilipMetzger
left a comment
PhilipMetzger
left a comment
There was a problem hiding this comment.
LG after addressing Yuya's nits.
martinvonz
force-pushed
the
push-ktvkyyrulzom
branch
from
e4d9e24 to
a6aa6a6
Compare
I'm going to add a similar message for access denied. That will want an error message printed at the end. For consistency, let's do the same for non-file paths.
martinvonz
force-pushed
the
push-ktvkyyrulzom
branch
4 times, most recently
from
1480d70 to
ff79a02
Compare
yuja
approved these changes
May 31, 2024
Some backends, like the one we have at Google, can restrict access to certain files. For such files, if they return a regular `BackendError::ReadObject`, then that will terminate iteration in many cases (e.g. when diffing or listing files). This patch adds a new error variant for them to return instead, plus handling of such errors in diff output and in the working copy. In order to test the feature, I added a new commit backend that returns the new `ReadAccessDenied` error when the caller tries to read certain objects.
martinvonz
force-pushed
the
push-ktvkyyrulzom
branch
from
ff79a02 to
20816cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md