require poetry 1.8, recommend installing it via pipx#3758
Merged
Conversation
ilyagr
force-pushed
the
poetry18
branch
2 times, most recently
from
fc06f15 to
4effc2e
Compare
PhilipMetzger
previously approved these changes
May 26, 2024
Contributor
Author
|
I added a commit to remove the |
PhilipMetzger
approved these changes
May 27, 2024
I feel like recommending people install Poetry via a package manager was a mistake. Poetry only supports its latest version, and while newer versions are sort-of backward-compatible, they print warnings in different situations and have different bugs. Installing `pipx` via a package manager, OTOH, works fine, and its older versions work fine. Using Poetry 1.8+ allows us to use Poetry's new "non-package" mode, which would no longer print warnings if the user does `poetry install` instead of `poetry install --no-root`. It's likely that in newer versions of Poetry, it will become an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like recommending people install Poetry via a package manager was a mistake. Poetry only supports its latest version, and while newer versions are sort-of backward-compatible, they print warnings in different situations and have different bugs. Installing
pipxvia a package manager, OTOH, works fine, and its older versions work fine.Using Poetry 1.8+ allows us to use Poetry's new "non-package" mode, which would no longer print warnings if the user does
poetry installinstead ofpoetry install --no-root. It's likely that in newer versions of Poetry, it will become an error.I wanted to share it since it's loosely related to #3757. I think it's ready, but let me know if I forgot something.