Skip to content

RTECO-1074 - Remove redundendent functions in agent namespace#3566

Open
udaykb2 wants to merge 1 commit into
masterfrom
RTECO-1074-Remove-agent-redundent-functions-1
Open

RTECO-1074 - Remove redundendent functions in agent namespace#3566
udaykb2 wants to merge 1 commit into
masterfrom
RTECO-1074-Remove-agent-redundent-functions-1

Conversation

@udaykb2

@udaykb2 udaykb2 commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Summary

Add dependency reference to jfrog-cli-artifactory PR: jfrog/jfrog-cli-artifactory#495

This dependency reference bring the following changes:

Removes wrapper functions that were duplicating logic between agent/plugins/common and agent/skills/common. Specifically:

  • Moved ResolveAgentTargets, CopyExtractedToTargets, and related helpers up to agent/common (the single source of truth)
  • Deleted the per-namespace copies in plugins/common and skills/common
  • Updated all callers in install.go, update.go, list.go to call agentcommon.* directly
  • Moved tests to agent/common

@udaykb2 udaykb2 changed the title Remove redundendent functions in agent namespace RTECO-1074 - Remove redundendent functions in agent namespace Jun 22, 2026
@udaykb2 udaykb2 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jun 22, 2026
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-1 branch from 1b7c266 to c4cd0f2 Compare June 22, 2026 10:01
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-1 branch from c4cd0f2 to e291c72 Compare June 22, 2026 10:05
@udaykb2 udaykb2 requested review from a team, agrasth, bhanurp, itsmeleela, naveenku-jfrog and reshmifrog and removed request for a team June 22, 2026 10:11
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-1 branch from e291c72 to bb5ef6d Compare June 22, 2026 10:32
@udaykb2 udaykb2 force-pushed the RTECO-1074-Remove-agent-redundent-functions-1 branch from bb5ef6d to 114ad99 Compare June 22, 2026 10:40
@udaykb2 udaykb2 deployed to build-gate June 22, 2026 10:40 — with GitHub Actions Active
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeleela itsmeleela Awaiting requested review from itsmeleela itsmeleela was automatically assigned from jfrog/ecomatrix

@bhanurp bhanurp Awaiting requested review from bhanurp bhanurp was automatically assigned from jfrog/ecomatrix

@agrasth agrasth Awaiting requested review from agrasth agrasth was automatically assigned from jfrog/ecomatrix

@reshmifrog reshmifrog Awaiting requested review from reshmifrog reshmifrog was automatically assigned from jfrog/ecomatrix

@naveenku-jfrog naveenku-jfrog Awaiting requested review from naveenku-jfrog naveenku-jfrog was automatically assigned from jfrog/ecomatrix

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

improvement Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@udaykb2