Fix npm installer hanging after CLI download#3541
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
c583764 to
b548f1f
Compare
|
Gentle ping on this one. The CLA is signed and the change is ready: it disables socket pooling ( The only thing outstanding is the |
Signed-off-by: Aaron Mark <64331623+amarkdotdev@users.noreply.github.com>
b548f1f to
462626c
Compare
What changed
response.pipe(file)and wait for the stream to finish before chmodWhy
This addresses issue #3423, where
npm i -g jfrog-cli-v2-jfcould sit around for about a minute after the binary download completed. The directhttps.get(url)path was keeping the process alive long after the download had finished.Verification
node init.jsinbuild/npm/v2-jfbefore the change; it stayed alive past 30 seconds and left an emptybin/jftime node init.jscompleted in about 7 seconds in bothbuild/npm/v2-jfandbuild/npm/v2, and each command produced the expected binary