[ansible/platform] Make service user shells configurable#498
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
[ansible/artifactory])What this PR does / why we need it:
Adds service-user shell variables for the Ansible Platform roles:
artifactory_user_shellxray_user_shelldistribution_user_shellThe defaults remain
/bin/bash, so existing behavior is unchanged. Operators who need non-interactive service accounts can now set the relevant variable to/sbin/nologin,/usr/sbin/nologin, or another site-approved shell without patching the role tasks.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #488Verification:
git diff --checkrg "user_shell|service user shell|shell:" -n Ansible\ansible_collections\jfrog\platform\roles\artifactory Ansible\ansible_collections\jfrog\platform\roles\xray Ansible\ansible_collections\jfrog\platform\roles\distribution Ansible\ansible_collections\jfrog\platform\CHANGELOG.mdNot run:
ansible/ansible-lint, because they are not installed in this Windows workspace.Special notes for your reviewer:
I kept the default shell unchanged to avoid a behavior change for existing installations; this only exposes the hardening knob.
This was implemented with Codex assistance, with the patch kept focused and manually reviewed.