Skip to content

[ansible/artifactory] Fix indentation in nginx conf#456

Open
PolaricEntropy wants to merge 1 commit into
jfrog:masterfrom
PolaricEntropy:fix-nginx-conf-indentation
Open

[ansible/artifactory] Fix indentation in nginx conf#456
PolaricEntropy wants to merge 1 commit into
jfrog:masterfrom
PolaricEntropy:fix-nginx-conf-indentation

Conversation

@PolaricEntropy

@PolaricEntropy PolaricEntropy commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with installer/product name (e.g. [ansible/artifactory])
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md

What this PR does / why we need it:
This PR fixes broken indentation and adjusts it to 4 spaces to ensure consistency with the nginx config generator inside Artifactory.
It makes it easier to do modifications to artifactory.conf going forward.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Does not fix any reported issue.

Special notes for your reviewer:
If artifactory_docker_registry_subdomain=true, the "chunked_transfer_encoding on;" line was placed on the same line as the rewrite rule, this PR fixes this along with other cosmetic changes.

It's possible to test these changes by installing the modified collection and running the playbook. The collection can be installed with the following command:

ansible-galaxy collection install git+https://github.com/PolaricEntropy/JFrog-Cloud-Installers.git#/Ansible/ansible_collections/jfrog/platform/,fix-nginx-conf-indentation

…ith the nginx config generator inside Artifactory

@srinivasgowda097 srinivasgowda097 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soumyas-dev soumyas-dev requested a review from chukka August 18, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants