Skip to content

Various improvements for SignInWithEthereum Authentication - #15649

Open
lachlan-roberts wants to merge 1 commit into
jetty-12.1.xfrom
fix/jetty-12.1.x/EthereumAuthenticator
Open

Various improvements for SignInWithEthereum Authentication#15649
lachlan-roberts wants to merge 1 commit into
jetty-12.1.xfrom
fix/jetty-12.1.x/EthereumAuthenticator

Conversation

@lachlan-roberts

Copy link
Copy Markdown
Member
  • Use Set instead of IncludeExcludeSet for domains and chainIds since exclude was never used.
  • Improve testing for SIWE authentication.
  • Other improvements such as the strengthening the defaults when domain set is not configured.

Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

1 participant