Skip to content

[12.1.x] Improve *AuthenticationProtocolHandler.accept() - #15629

Open
sbordet wants to merge 1 commit into
jetty-12.1.xfrom
fix/jetty-12.1.x/precise-authnph
Open

[12.1.x] Improve *AuthenticationProtocolHandler.accept()#15629
sbordet wants to merge 1 commit into
jetty-12.1.xfrom
fix/jetty-12.1.x/precise-authnph

Conversation

@sbordet

@sbordet sbordet commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Made *AuthenticationProtocolHandler.accept() more precise, as they are exclusive: when one accepts the other should not.

@lorban lorban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This break related tests, which seem to indicate this improvement needs more thoughts.

@sbordet
sbordet force-pushed the fix/jetty-12.1.x/precise-authnph branch from 87a97f9 to 5c973e9 Compare August 25, 2026 07:33
…tunnel cases and same-protocol clear-text cases.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
sbordet force-pushed the fix/jetty-12.1.x/precise-authnph branch from 5c973e9 to 65fd729 Compare August 25, 2026 08:07
@sbordet
sbordet requested a review from lorban August 25, 2026 08:08

@lorban lorban left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More broken tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants