Fix incorrect eager aborting of H2 channels during graceful shutdown - #15628
Open
lorban wants to merge 3 commits into
Open
Fix incorrect eager aborting of H2 channels during graceful shutdown#15628lorban wants to merge 3 commits into
lorban wants to merge 3 commits into
Conversation
- make the lower-layer call HttpConnectionOverHTTP2.upwardClose() instead of close() - introduce a zero channel action that is executed when the last channel gets released/destroyed instead of when the lower layer notifies that it is done Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #15368
Needs to be backported to 12.0.x.